Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.h

Issue 2625813003: MacViews: Allow the toolkit-views Enterprise Signin Confirmation Dialog to be used (Closed)
Patch Set: Rebase (DID NOT LAND) Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.h
diff --git a/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.h b/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.h
index b3983610adec0607911ab679f841cb8001556ce3..39a1bdd4f70bb35689961bf0d4ea38a1dd63c5d9 100644
--- a/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.h
+++ b/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_UI_COCOA_PROFILES_PROFILE_SIGNIN_CONFIRMATION_VIEW_CONTROLLER_H_
#import <Cocoa/Cocoa.h>
+#include <memory>
#include <string>
#include "base/callback.h"
@@ -33,7 +34,7 @@ class ProfileSigninConfirmationDelegate;
bool offerProfileCreation_;
// Dialog button callbacks.
- ui::ProfileSigninConfirmationDelegate* delegate_;
+ std::unique_ptr<ui::ProfileSigninConfirmationDelegate> delegate_;
base::Closure closeDialogCallback_;
// UI elements.
@@ -48,10 +49,12 @@ class ProfileSigninConfirmationDelegate;
}
- (id)initWithBrowser:(Browser*)browser
- username:(const std::string&)username
- delegate:(ui::ProfileSigninConfirmationDelegate*)delegate
- closeDialogCallback:(const base::Closure&)closeDialogCallback
- offerProfileCreation:(bool)offer;
+ username:(const std::string&)username
+ delegate:
+ (std::unique_ptr<ui::ProfileSigninConfirmationDelegate>)
+ delegate
+ closeDialogCallback:(const base::Closure&)closeDialogCallback
+ offerProfileCreation:(bool)offer;
- (IBAction)cancel:(id)sender;
- (IBAction)ok:(id)sender;
- (IBAction)close:(id)sender;
@@ -59,12 +62,4 @@ class ProfileSigninConfirmationDelegate;
@end
-@interface ProfileSigninConfirmationViewController (TestingAPI)
-
-@property(readonly, nonatomic) ui::ProfileSigninConfirmationDelegate* delegate;
-@property(readonly, nonatomic) NSButton* createProfileButton;
-@property(readonly, nonatomic) NSTextView* explanationField;
-
-@end
-
#endif // CHROME_BROWSER_UI_COCOA_PROFILES_PROFILE_SIGNIN_CONFIRMATION_VIEW_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698