MacViews: Allow the toolkit-views Enterprise Signin Confirmation Dialog to be used

chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views_browsertest.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h"
+
+#include "base/command_line.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/bookmarks/bookmark_model_factory.h"
+#include "chrome/browser/ui/sync/profile_signin_confirmation_helper.h"
+#include "chrome/browser/ui/tab_dialogs.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/test/test_browser_dialog.h"
+#include "components/bookmarks/browser/bookmark_model.h"
+#include "ui/base/ui_base_switches.h"
+
+namespace {
+
+class TestSigninDialogDelegate : public ui::ProfileSigninConfirmationDelegate {

[msw, 2017/01/13 23:23:51]

optional nit: comment

[tapted, 2017/01/13 23:48:45]

Done.

+ public:
+  TestSigninDialogDelegate() {}
+  virtual ~TestSigninDialogDelegate() {}
+
+  void OnCancelSignin() override {}
+  void OnContinueSignin() override {}
+  void OnSigninWithNewProfile() override {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TestSigninDialogDelegate);
+};
+
+}  // namespace
+
+class ProfileSigninConfirmationDialogTest : public DialogBrowserTest {
+ public:
+  ProfileSigninConfirmationDialogTest() {}
+
+  // content::BrowserTestBase:
+  void SetUpCommandLine(base::CommandLine* command_line) override {
+    command_line->AppendSwitch(switches::kExtendMdToSecondaryUi);
+  }
+
+  // TestDialogInterface:

[msw, 2017/01/13 23:23:51]

nit: use the appropriate base class name.
(optionally also fix collected_cookies_browsertest.cc)

[tapted, 2017/01/13 23:48:45]

Done & Done. Although I guess I should start a chromium-dev thread about this
;).

I see the appeal of picking something from the list of direct base classes, and
that's the more consistent approach for now. However, another interpretation is
that this comment appears in lieu of duplicating the "real" function comments,
so it should point to the class declaration that has those comments (which may
not be a direct base class).

[msw, 2017/01/13 23:53:52]

I'm not picky, just don't use the non-existent 'TestDialogInterface' :)

[tapted, 2017/01/14 00:06:23]

Ohhhhh. Doh - you're right. I forgot I renamed it to TestBrowserDialog :/.

I may actually circle back on that -- I picked TestBrowserDialog to match the
filename. And although DialogBrowserTest feels nice (e.g. as a replacement for
InProcessBrowserTest), I find I'm mixing up the order of things in
TestBrowserDialog :/ (probably because BrowserDialogTest is also taken by the
actual test harness in browser_dialog_browsertest.cc). Maybe
DialogBrowserTestInterface and dialog_browser_test.h... (and
dialog_browser_test_browsertest.cc..)

Anyway that's orthogonal, and I guess it means "DialogBrowserTest" is best for
the comment here, because that's the name I'm not thinking about changing :)

+  void ShowDialog(const std::string& name) override {
+    Profile* profile = browser()->profile();
+
+    // Add a bookmark to ensure CheckShouldPromptForNewProfile() returns true.
+    bookmarks::BookmarkModel* bookmarks =
+        BookmarkModelFactory::GetForBrowserContext(profile);
+    bookmarks->AddURL(bookmarks->bookmark_bar_node(), 0,
+                      base::ASCIIToUTF16("title"),
+                      GURL("http://www.example.com"));
+
+    content::WebContents* web_contents =
+        browser()->tab_strip_model()->GetActiveWebContents();
+    TabDialogs::FromWebContents(web_contents)
+        ->ShowProfileSigninConfirmation(
+            browser(), profile, "username@example.com",
+            base::MakeUnique<TestSigninDialogDelegate>());
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ProfileSigninConfirmationDialogTest);
+};
+
+// Test that calls ShowDialog("default"). Interactive when run via
+// browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive
+// --dialog=ProfileSigninConfirmationDialogTest.InvokeDialog_default
+IN_PROC_BROWSER_TEST_F(ProfileSigninConfirmationDialogTest,
+                       InvokeDialog_default) {
+  RunDialog();
+}