Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 26258003: Add a full QWERTY layout. (Closed)

Created:
7 years, 2 months ago by rsadam
Modified:
7 years, 2 months ago
Reviewers:
sadrul, bshe, kevers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adds a full QWERTY layout to the Virtual Keyboard. BUG=297772 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228031

Patch Set 1 : Add a system layout. #

Patch Set 2 : Accidentally modified a webui file #

Total comments: 7

Patch Set 3 : Fixed nits. #

Patch Set 4 : Fixed keycodes. Set as default layout for passwords. #

Total comments: 4

Patch Set 5 : Fix edge case in WebUI #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -13 lines) Patch
M ui/keyboard/keyboard_resources.grd View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard_ui_controller.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/resources/api_adapter.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/elements/kb-key-base.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/keyboard/resources/elements/kb-key-sequence.html View 1 2 3 4 2 chunks +10 lines, -2 lines 0 comments Download
M ui/keyboard/resources/elements/kb-keyboard.html View 1 2 3 4 3 chunks +23 lines, -7 lines 2 comments Download
A ui/keyboard/resources/layouts/system-qwerty.html View 1 2 3 1 chunk +77 lines, -0 lines 0 comments Download
M ui/keyboard/resources/webui/api_adapter.js View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
rsadam
7 years, 2 months ago (2013-10-07 17:37:34 UTC) #1
rsadam
7 years, 2 months ago (2013-10-07 17:43:00 UTC) #2
bshe
https://codereview.chromium.org/26258003/diff/5001/ui/keyboard/keyboard_util.cc File ui/keyboard/keyboard_util.cc (right): https://codereview.chromium.org/26258003/diff/5001/ui/keyboard/keyboard_util.cc#newcode187 ui/keyboard/keyboard_util.cc:187: {"keyboard/layouts/system.html", IDR_KEYBOARD_LAYOUTS_SYSTEM}, nit: alphabetical please https://codereview.chromium.org/26258003/diff/5001/ui/keyboard/resources/elements/kb-key-sequence.html File ui/keyboard/resources/elements/kb-key-sequence.html (right): ...
7 years, 2 months ago (2013-10-08 14:58:06 UTC) #3
kevers
Drive by review. https://codereview.chromium.org/26258003/diff/5001/ui/keyboard/keyboard_util.cc File ui/keyboard/keyboard_util.cc (right): https://codereview.chromium.org/26258003/diff/5001/ui/keyboard/keyboard_util.cc#newcode187 ui/keyboard/keyboard_util.cc:187: {"keyboard/layouts/system.html", IDR_KEYBOARD_LAYOUTS_SYSTEM}, On 2013/10/08 14:58:06, bshe ...
7 years, 2 months ago (2013-10-08 15:39:48 UTC) #4
rsadam
https://chromiumcodereview.appspot.com/26258003/diff/5001/ui/keyboard/keyboard_util.cc File ui/keyboard/keyboard_util.cc (right): https://chromiumcodereview.appspot.com/26258003/diff/5001/ui/keyboard/keyboard_util.cc#newcode187 ui/keyboard/keyboard_util.cc:187: {"keyboard/layouts/system.html", IDR_KEYBOARD_LAYOUTS_SYSTEM}, On 2013/10/08 15:39:48, kevers wrote: > On ...
7 years, 2 months ago (2013-10-08 21:36:14 UTC) #5
rsadam
On 2013/10/08 21:36:14, rsadam wrote: > https://chromiumcodereview.appspot.com/26258003/diff/5001/ui/keyboard/keyboard_util.cc > File ui/keyboard/keyboard_util.cc (right): > > https://chromiumcodereview.appspot.com/26258003/diff/5001/ui/keyboard/keyboard_util.cc#newcode187 > ...
7 years, 2 months ago (2013-10-08 21:38:00 UTC) #6
rsadam
Rebased to master, fixed keycodes and set as default layout when dealing with passwords! https://codereview.chromium.org/26258003/diff/5001/ui/keyboard/resources/elements/kb-key-sequence.html ...
7 years, 2 months ago (2013-10-09 15:25:12 UTC) #7
bshe
lgtm with nits https://codereview.chromium.org/26258003/diff/25001/ui/keyboard/resources/elements/kb-key-sequence.html File ui/keyboard/resources/elements/kb-key-sequence.html (right): https://codereview.chromium.org/26258003/diff/25001/ui/keyboard/resources/elements/kb-key-sequence.html#newcode7 ui/keyboard/resources/elements/kb-key-sequence.html:7: <polymer-element name="kb-key-sequence" attributes="keys hintTexts keyCodes invert"> ...
7 years, 2 months ago (2013-10-09 16:07:49 UTC) #8
rsadam
https://codereview.chromium.org/26258003/diff/25001/ui/keyboard/resources/elements/kb-key-sequence.html File ui/keyboard/resources/elements/kb-key-sequence.html (right): https://codereview.chromium.org/26258003/diff/25001/ui/keyboard/resources/elements/kb-key-sequence.html#newcode7 ui/keyboard/resources/elements/kb-key-sequence.html:7: <polymer-element name="kb-key-sequence" attributes="keys hintTexts keyCodes invert"> On 2013/10/09 16:07:50, ...
7 years, 2 months ago (2013-10-09 19:04:45 UTC) #9
rsadam
+sadrul for OWNERS
7 years, 2 months ago (2013-10-09 19:05:39 UTC) #10
sadrul
non-JS/HTML code lgtm
7 years, 2 months ago (2013-10-09 19:26:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/26258003/41001
7 years, 2 months ago (2013-10-09 19:42:11 UTC) #12
bshe
https://codereview.chromium.org/26258003/diff/41001/ui/keyboard/resources/elements/kb-keyboard.html File ui/keyboard/resources/elements/kb-keyboard.html (right): https://codereview.chromium.org/26258003/diff/41001/ui/keyboard/resources/elements/kb-keyboard.html#newcode249 ui/keyboard/resources/elements/kb-keyboard.html:249: inputTypeChanged: function() { we can probably just override inputType ...
7 years, 2 months ago (2013-10-09 19:42:54 UTC) #13
rsadam
https://codereview.chromium.org/26258003/diff/41001/ui/keyboard/resources/elements/kb-keyboard.html File ui/keyboard/resources/elements/kb-keyboard.html (right): https://codereview.chromium.org/26258003/diff/41001/ui/keyboard/resources/elements/kb-keyboard.html#newcode249 ui/keyboard/resources/elements/kb-keyboard.html:249: inputTypeChanged: function() { As we discussed offline, that will ...
7 years, 2 months ago (2013-10-09 20:18:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/26258003/41001
7 years, 2 months ago (2013-10-10 17:35:21 UTC) #15
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=87529
7 years, 2 months ago (2013-10-10 20:13:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/26258003/41001
7 years, 2 months ago (2013-10-10 20:19:34 UTC) #17
commit-bot: I haz the power
7 years, 2 months ago (2013-10-10 22:34:42 UTC) #18
Message was sent while issue was closed.
Change committed as 228031

Powered by Google App Engine
This is Rietveld 408576698