Explicitly compute analysis results for sources to check errors.

pkg/analyzer/test/generated/non_hint_code_test.dart

Index: pkg/analyzer/test/generated/non_hint_code_test.dart
diff --git a/pkg/analyzer/test/generated/non_hint_code_test.dart b/pkg/analyzer/test/generated/non_hint_code_test.dart
index b3a88377ea6d4174041fd838a90512c236280f5e..bf51cf005e8bf635e569ae395fa79f1482fd816f 100644
--- a/pkg/analyzer/test/generated/non_hint_code_test.dart
+++ b/pkg/analyzer/test/generated/non_hint_code_test.dart
@@ -32,6 +32,7 @@ class B extends A {
   }
 }
 ''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -50,6 +51,7 @@ f() {
   throw 'foo';
 }
 ''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -60,6 +62,7 @@ const bool DEBUG = true;
 f() {
   DEBUG ? 1 : 2;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -70,6 +73,7 @@ const bool DEBUG = false;
 f() {
   DEBUG ? 1 : 2;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -80,6 +84,7 @@ const bool DEBUG = true;
 f() {
   if(DEBUG) {} else {}
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -92,6 +97,7 @@ class A {
 f() {
   if(A.DEBUG) {}
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -110,6 +116,7 @@ library lib2;
 class A {
   static const bool DEBUG = false;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -128,6 +135,7 @@ library lib2;
 class A {
   static const bool DEBUG = false;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -138,6 +146,7 @@ const bool DEBUG = false;
 f() {
   if(DEBUG) {}
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -148,6 +157,7 @@ const bool DEBUG = false;
 f() {
   while(DEBUG) {}
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -159,6 +169,7 @@ class B extends A {}
 f() {
   try {} on B catch (e) {} on A catch (e) {} catch (e) {}
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -178,6 +189,7 @@ f() {
     break;
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -188,6 +200,7 @@ const bool DEBUG = false;
 f() {
   bool b = DEBUG && false;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -198,6 +211,7 @@ const bool DEBUG = true;
 f() {
   bool b = DEBUG || true;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -210,6 +224,7 @@ f() {
   }
   int a = 1;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -226,6 +241,7 @@ class C {
   }
 }
 ''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -240,6 +256,7 @@ g() {
   f();
 }
 ''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -258,6 +275,7 @@ class C {
   }
 }
 ''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -274,6 +292,7 @@ class C {
   }
 }
 ''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -291,6 +310,7 @@ class C {
   }
 }
 ''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -300,6 +320,7 @@ class C {
 f(int x, int y) {
   var v = x / y.toInt();
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -309,6 +330,7 @@ f(int x, int y) {
 f(x, y) {
   var v = (x / y).toInt();
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -321,6 +343,7 @@ class A {
 f(A x, A y) {
   var v = (x / y).toInt();
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -337,6 +360,7 @@ one.A a2;''');
         r'''
 library lib1;
 class A {}''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -354,6 +378,7 @@ B b;''');
 library lib1;
 class A {}
 class B {}''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -371,6 +396,7 @@ B b;''');
 library lib1;
 class A {}
 class B {}''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -396,6 +422,7 @@ f(var message, var dynamic_) {
   }
   int s = message;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -412,6 +439,7 @@ f(var message) {
   }
   int s = message;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -427,6 +455,7 @@ f(var message) {
   }
   String s = message;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -436,24 +465,28 @@ f(var message) {
 abstract class A {
   int m();
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
 
   test_missingReturn_expressionFunctionBody() async {
     Source source = addSource("int f() => 0;");
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
 
   test_missingReturn_noReturnType() async {
     Source source = addSource("f() {}");
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
 
   test_missingReturn_voidReturnType() async {
     Source source = addSource("void f() {}");
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -464,6 +497,7 @@ m(x) {
   for (var v = x; ; v++) {}
 }
 ''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -474,6 +508,7 @@ m(x) {
   if (x?.y == null) {}
 }
 ''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -484,6 +519,7 @@ class A {
   bool operator ==(x) { return x; }
   get hashCode => 0;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -503,6 +539,7 @@ class B implements A {
   @override
   int c;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -522,6 +559,7 @@ class B extends A {
   @override
   int c;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -535,6 +573,7 @@ class B implements A {
   @override
   int get m => 1;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -548,6 +587,7 @@ class B extends A {
   @override
   int get m => 1;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -561,6 +601,7 @@ class B implements A {
   @override
   int m() => 1;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -574,6 +615,7 @@ class B extends A {
   @override
   int m() => 1;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -587,6 +629,7 @@ class B extends A {
   @override
   int m() => 1;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -600,6 +643,7 @@ class B implements A {
   @override
   set m(int x) {}
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -613,6 +657,7 @@ class B extends A {
   @override
   set m(int x) {}
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -629,6 +674,7 @@ class Z {
     y.x.add(new A());
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -647,6 +693,7 @@ f(var a) {
   a++;
   ++a;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -666,6 +713,7 @@ class B {
     ++a;
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -685,6 +733,7 @@ class B {
 }
 @proxy
 class A {}''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -699,6 +748,7 @@ f(var a) {
     return a.b;
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -713,6 +763,7 @@ f(var a, var a2) {
   a2 = new A();
   a += a2;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -722,6 +773,7 @@ class D<T extends dynamic> {
   fieldAccess(T t) => t.abc;
   methodAccess(T t) => t.xyz(1, 2, 'three');
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -735,6 +787,7 @@ f() {
   var a = new A();
   a.b();
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -755,6 +808,7 @@ f(A a, B b) {
   }
   ab.m();
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -773,6 +827,7 @@ f(A a, B b) {
   }
   ab.m(0);
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -787,6 +842,7 @@ f(var a) {
     a + 1;
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -801,6 +857,7 @@ f(var a) {
     a[0]++;
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -815,6 +872,7 @@ f(var a) {
     a[0];
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -829,6 +887,7 @@ f(var a) {
     a[0] = 1;
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -843,6 +902,7 @@ f(var a) {
     a++;
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -857,6 +917,7 @@ f(var a) {
     ++a;
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -871,6 +932,7 @@ f(var a) {
     a.b = 0;
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -886,6 +948,7 @@ class B<E> {
     (e as A).a();
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -898,6 +961,7 @@ class B implements I {}
 I m(A a, B b) {
   return a == null ? b as I : a as I;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -907,6 +971,7 @@ I m(A a, B b) {
 m(v) {
   var b = v as Object;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -919,6 +984,7 @@ Future<int> f() => new Future.value(0);
 void g(bool c) {
   (c ? f(): new Future.value(0) as Future<int>).then((int value) {});
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -928,6 +994,7 @@ void g(bool c) {
 m(v) {
   var b = Object as dynamic;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -943,6 +1010,7 @@ class B extends A {
     print(y);
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -959,6 +1027,7 @@ class B extends A {
     return super.noSuchMethod(y);
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -972,6 +1041,7 @@ class B extends A {
   mmm();
   noSuchMethod(y) => super.hashCode;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -985,6 +1055,7 @@ class B extends A {
   mmm();
   noSuchMethod(y) => 42;
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -1001,6 +1072,8 @@ library lib1;
 class A {
   const A() {}
 }''');
+    await computeAnalysisResult(source);
+    await computeAnalysisResult(source2);
     await assertErrors(source);
     verify([source, source2]);
   }
@@ -1023,6 +1096,9 @@ class A {}''');
         r'''
 library lib2;
 class B {}''');
+    await computeAnalysisResult(source);
+    await computeAnalysisResult(source2);
+    await computeAnalysisResult(source3);
     await assertErrors(source);
     await assertNoErrors(source2);
     await assertNoErrors(source3);
@@ -1033,6 +1109,7 @@ class B {}''');
     Source source = addSource(r'''
 library L;
 import 'dart:core';''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -1053,6 +1130,7 @@ class One {}''');
         r'''
 library lib2;
 class Two {}''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -1079,6 +1157,7 @@ class Two {}''');
         r'''
 library lib3;
 class Three {}''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -1106,6 +1185,7 @@ class Two {}''');
 library lib3;
 export 'lib2.dart';
 class Three {}''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -1124,6 +1204,7 @@ class A {
         r'''
 library lib1;
 const x = 0;''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -1145,6 +1226,7 @@ class A {
 library lib1;
 class One {}
 topLevelFunction() {}''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -1168,6 +1250,7 @@ class A {
 library lib1;
 class One {}
 topLevelFunction() {}''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -1180,6 +1263,7 @@ class A {
     var a = f();
   }
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -1190,6 +1274,7 @@ int f() => 1;
 g() {
   var a = f();
 }''');
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
     verify([source]);
   }
@@ -1198,11 +1283,13 @@ g() {
 class PubSuggestionCodeTest extends ResolverTestCase {
   test_import_package() async {
     Source source = addSource("import 'package:somepackage/other.dart';");
+    await computeAnalysisResult(source);
     await assertErrors(source, [CompileTimeErrorCode.URI_DOES_NOT_EXIST]);
   }
 
   test_import_packageWithDotDot() async {
     Source source = addSource("import 'package:somepackage/../other.dart';");
+    await computeAnalysisResult(source);
     await assertErrors(source, [
       CompileTimeErrorCode.URI_DOES_NOT_EXIST,
       HintCode.PACKAGE_IMPORT_CONTAINS_DOT_DOT
@@ -1211,6 +1298,7 @@ class PubSuggestionCodeTest extends ResolverTestCase {
 
   test_import_packageWithLeadingDotDot() async {
     Source source = addSource("import 'package:../other.dart';");
+    await computeAnalysisResult(source);
     await assertErrors(source, [
       CompileTimeErrorCode.URI_DOES_NOT_EXIST,
       HintCode.PACKAGE_IMPORT_CONTAINS_DOT_DOT
@@ -1222,6 +1310,7 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/lib/other.dart", "");
     Source source =
         addNamedSource("/myproj/web/test.dart", "import '../lib/other.dart';");
+    await computeAnalysisResult(source);
     await assertErrors(
         source, [HintCode.FILE_IMPORT_OUTSIDE_LIB_REFERENCES_FILE_INSIDE]);
   }
@@ -1230,6 +1319,7 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/lib/other.dart", "");
     Source source =
         addNamedSource("/myproj/web/test.dart", "import '../lib/other.dart';");
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -1238,6 +1328,7 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/web/other.dart", "");
     Source source =
         addNamedSource("/myproj/lib/test.dart", "import '../web/other.dart';");
+    await computeAnalysisResult(source);
     await assertErrors(
         source, [HintCode.FILE_IMPORT_INSIDE_LIB_REFERENCES_FILE_OUTSIDE]);
   }
@@ -1246,6 +1337,7 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/web/other.dart", "");
     Source source =
         addNamedSource("/myproj/lib/test.dart", "import '../web/other.dart';");
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -1254,6 +1346,7 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/lib/other.dart", "");
     Source source =
         addNamedSource("/myproj/lib/test.dart", "import 'other.dart';");
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -1262,6 +1355,7 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/lib/bar/other.dart", "");
     Source source = addNamedSource(
         "/myproj/lib/foo/test.dart", "import '../bar/other.dart';");
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 
@@ -1270,6 +1364,7 @@ class PubSuggestionCodeTest extends ResolverTestCase {
     cacheSource("/myproj/web/other.dart", "");
     Source source =
         addNamedSource("/myproj/lib2/test.dart", "import '../web/other.dart';");
+    await computeAnalysisResult(source);
     await assertNoErrors(source);
   }
 }