pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart - Issue 2625783002: Explicitly compute analysis results for sources to check errors.

Unified Diff: pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart

Issue 2625783002: Explicitly compute analysis results for sources to check errors. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « pkg/analyzer/test/generated/all_the_rest_test.dart ('k') | pkg/analyzer/test/generated/compile_time_error_code_test.dart » ('j') | pkg/analyzer/test/generated/compile_time_error_code_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart

diff --git a/pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart b/pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart

index a580660e1fff5859fdb8726c01aea74c8b00cd48..e1caf4da8da88076653229475c6cffd7a7cea4b1 100644

--- a/pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart

+++ b/pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart

@@ -34,6 +34,7 @@ class C {

const C(this.a);

}

var v = const C(const B());''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -47,6 +48,7 @@ class A {

const A(String this.x);

}

var v = const A(null);''');

+ await computeAnalysisResult(source);

await assertErrors(source, [StaticWarningCode.UNDEFINED_CLASS]);

verify([source]);

}

@@ -65,6 +67,7 @@ class C {

const C(this.a);

}

var v = const C(const B());''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -76,6 +79,7 @@ class A {

const A(List<int> x);

}

var x = const A(const [1, 2, 3]);''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -87,6 +91,7 @@ class A {

const A(List<num> x);

}

var x = const A(const <int>[1, 2, 3]);''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -99,6 +104,7 @@ class A {

const A(Map<int, int> x);

}

var x = const A(const {1: 2});''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -111,6 +117,7 @@ class A {

const A(Map<num, int> x);

}

var x = const A(const <int, int>{1: 2});''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -123,6 +130,7 @@ class A {

const A(Map<int, num> x);

}

var x = const A(const <int, int>{1: 2});''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -136,6 +144,7 @@ class A {

const A(this.x);

}

var v = const A(5);''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -148,6 +157,7 @@ class A {

const A(this.x);

}

var v = const A(null);''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -163,6 +173,7 @@ class A {

}

foo(x) => 1;

var v = const A(foo);''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -176,6 +187,7 @@ class A<T> {

const A(this.x);

}

var v = const A<int>(3);''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -187,6 +199,7 @@ class A {

const A(this.x);

}

var v = const A('foo');''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH,

StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE

@@ -210,6 +223,7 @@ class C {

const C(this.b);

}

var v = const C(const A());''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH

]);

@@ -223,6 +237,7 @@ class A {

const A(String this.x);

}

var v = const A('foo');''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH,

StaticWarningCode.FIELD_INITIALIZING_FORMAL_NOT_ASSIGNABLE

@@ -237,6 +252,7 @@ class A {

const A(String this.x);

}

var v = const A('foo');''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH,

StaticWarningCode.UNDEFINED_CLASS

@@ -258,6 +274,7 @@ class C {

const C(this.b);

}

var v = const C(const A());''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH

]);

@@ -271,6 +288,7 @@ class A {

const A(List<int> x);

}

var x = const A(const <num>[1, 2, 3]);''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH

]);

@@ -285,6 +303,7 @@ class A {

const A(Map<int, int> x);

}

var x = const A(const <num, int>{1: 2});''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH

]);

@@ -299,6 +318,7 @@ class A {

const A(Map<int, int> x);

}

var x = const A(const <int, num>{1: 2});''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH

]);

@@ -312,6 +332,7 @@ class A {

const A([this.x = 'foo']);

}

var v = const A();''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH,

StaticTypeWarningCode.INVALID_ASSIGNMENT

@@ -330,6 +351,7 @@ class A {

}

int foo(String x) => 1;

var v = const A(foo);''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH,

StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE

@@ -343,6 +365,7 @@ class A {

final int x;

const A() : x = '';

}''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_FIELD_INITIALIZER_NOT_ASSIGNABLE,

StaticWarningCode.FIELD_INITIALIZER_NOT_ASSIGNABLE

@@ -357,6 +380,7 @@ class A {

final int y;

}

var v = const A('foo');''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_FIELD_TYPE_MISMATCH

]);

@@ -372,6 +396,7 @@ class C<T> {

const int y = 1;

var v = const C<String>();

''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_FIELD_TYPE_MISMATCH,

StaticTypeWarningCode.INVALID_ASSIGNMENT

@@ -386,6 +411,7 @@ class A {

final Unresolved y;

}

var v = const A('foo');''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_FIELD_TYPE_MISMATCH,

StaticWarningCode.UNDEFINED_CLASS

@@ -402,6 +428,7 @@ class C<T> {

const int y = 1;

var v = const C<int>();

''');

+ await computeAnalysisResult(source);

await assertErrors(source, [StaticTypeWarningCode.INVALID_ASSIGNMENT]);

verify([source]);

}

@@ -413,6 +440,7 @@ class A {

final int y;

}

var v = const A(null);''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -426,12 +454,14 @@ class A {

final Unresolved y;

}

var v = const A(null);''');

+ await computeAnalysisResult(source);

await assertErrors(source, [StaticWarningCode.UNDEFINED_CLASS]);

verify([source]);

}

test_listElementTypeNotAssignable() async {

Source source = addSource("var v = const <String> [42];");

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.LIST_ELEMENT_TYPE_NOT_ASSIGNABLE,

StaticWarningCode.LIST_ELEMENT_TYPE_NOT_ASSIGNABLE

@@ -441,6 +471,7 @@ var v = const A(null);''');

test_mapKeyTypeNotAssignable() async {

Source source = addSource("var v = const <String, int > {1 : 2};");

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.MAP_KEY_TYPE_NOT_ASSIGNABLE,

StaticWarningCode.MAP_KEY_TYPE_NOT_ASSIGNABLE

@@ -450,6 +481,7 @@ var v = const A(null);''');

test_mapValueTypeNotAssignable() async {

Source source = addSource("var v = const <String, String> {'a' : 2};");

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.MAP_VALUE_TYPE_NOT_ASSIGNABLE,

StaticWarningCode.MAP_VALUE_TYPE_NOT_ASSIGNABLE

@@ -464,6 +496,7 @@ class A {

const A(int x);

}

var v = const A(null);''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -474,6 +507,7 @@ class A<T> {

const A(T x);

}

var v = const A<int>(3);''');

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -486,6 +520,7 @@ class A {

const A(Unresolved x);

}

var v = const A(null);''');

+ await computeAnalysisResult(source);

await assertErrors(source, [StaticWarningCode.UNDEFINED_CLASS]);

verify([source]);

}

@@ -496,6 +531,7 @@ class A {

const A(int x);

}

var v = const A('foo');''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH,

StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE

@@ -509,6 +545,7 @@ class A<T> {

const A(T x);

}

var v = const A<int>('foo');''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH,

StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE

@@ -522,6 +559,7 @@ class A {

const A(Unresolved x);

}

var v = const A('foo');''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH,

StaticWarningCode.UNDEFINED_CLASS

@@ -536,6 +574,7 @@ class A {

const A.a2(String x);

}

var v = const A.a1(0);''');

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH

]);

@@ -544,6 +583,7 @@ var v = const A.a1(0);''');

test_topLevelVarAssignable_null() async {

Source source = addSource("const int x = null;");

+ await computeAnalysisResult(source);

await assertNoErrors(source);

verify([source]);

}

@@ -552,12 +592,14 @@ var v = const A.a1(0);''');

// Null always passes runtime type checks, even when the type is

// unresolved.

Source source = addSource("const Unresolved x = null;");

+ await computeAnalysisResult(source);

await assertErrors(source, [StaticWarningCode.UNDEFINED_CLASS]);

verify([source]);

}

test_topLevelVarNotAssignable() async {

Source source = addSource("const int x = 'foo';");

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.VARIABLE_TYPE_MISMATCH,

StaticTypeWarningCode.INVALID_ASSIGNMENT

@@ -567,6 +609,7 @@ var v = const A.a1(0);''');

test_topLevelVarNotAssignable_undefined() async {

Source source = addSource("const Unresolved x = 'foo';");

+ await computeAnalysisResult(source);

await assertErrors(source, [

CheckedModeCompileTimeErrorCode.VARIABLE_TYPE_MISMATCH,

StaticWarningCode.UNDEFINED_CLASS