Reenable framebusting

third_party/WebKit/Source/core/frame/LocalFrame.h

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999-2001 Lars Knoll <knoll@kde.org>
  *                     1999-2001 Antti Koivisto <koivisto@kde.org>
  *                     2000-2001 Simon Hausmann <hausmann@kde.org>
  *                     2000-2001 Dirk Mueller <mueller@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
@@ skipping 105 matching lines @@
   void reload(FrameLoadType, ClientRedirectPolicy) override;
   void detach(FrameDetachType) override;
   bool shouldClose() override;
   SecurityContext* securityContext() const override;
   void printNavigationErrorMessage(const Frame&, const char* reason) override;
   void printNavigationWarning(const String&) override;
   bool prepareForCommit() override;
   void didChangeVisibilityState() override;
   void setDocumentHasReceivedUserGesture() override;
 
+  bool hasReceivedUserGesture() const { return m_hasReceivedUserGesture; }
+
   void detachChildren();
   void documentAttached();
 
   LocalDOMWindow* domWindow() const;
   void setDOMWindow(LocalDOMWindow*);
   FrameView* view() const;
   Document* document() const;
   void setPagePopupOwner(Element&);
   Element* pagePopupOwner() const { return m_pagePopupOwner.get(); }
 
@@ skipping 126 matching lines @@
   const Member<FrameConsole> m_console;
   const Member<InputMethodController> m_inputMethodController;
   const Member<IdleSpellCheckCallback> m_idleSpellCheckCallback;
 
   int m_navigationDisableCount;
 
   float m_pageZoomFactor;
   float m_textZoomFactor;
 
   bool m_inViewSourceMode;
+  bool m_hasReceivedUserGesture;

[Nate Chapin, 2017/01/11 19:01:40]

This won't propagate if this frame goes cross-process. I don't know how much of
a problem that is in practice, but it does mean their would be a behavior
difference between site isolation enabled and disabled.

[ojan, 2017/01/11 19:15:48]

I think we need to come up with a solution that is unaffected by site isolation.
Unfortunately, I can't think of anything other than just making this work
properly across processes. 

Also, is there a test for showing that you can navigate the top-level page after
the frame has been navigated?

 
   Member<InstrumentingAgents> m_instrumentingAgents;
   Member<PerformanceMonitor> m_performanceMonitor;
 
   InterfaceProvider* const m_interfaceProvider;
   InterfaceRegistry* const m_interfaceRegistry;
 };
 
 inline void LocalFrame::init() {
   m_loader.init();
@@ skipping 96 matching lines @@
   explicit ScopedFrameBlamer(LocalFrame*);
   ~ScopedFrameBlamer();
 
  private:
   Member<LocalFrame> m_frame;
 };
 
 }  // namespace blink
 
 #endif  // LocalFrame_h