Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2217)

Unified Diff: pkg/compiler/lib/src/js_backend/js_interop_analysis.dart

Issue 2625713002: Rename Enqueuer.universe to worldBuilder. (Closed)
Patch Set: Fix. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/js_interop_analysis.dart
diff --git a/pkg/compiler/lib/src/js_backend/js_interop_analysis.dart b/pkg/compiler/lib/src/js_backend/js_interop_analysis.dart
index a89326b1d689608cdd0a6393e801f9f52b773851..c6da1ea56063e9c92857b4b2f325119ea446d002 100644
--- a/pkg/compiler/lib/src/js_backend/js_interop_analysis.dart
+++ b/pkg/compiler/lib/src/js_backend/js_interop_analysis.dart
@@ -117,7 +117,8 @@ class JsInteropAnalysis {
// Skip classes that are completely unreachable. This should only happen
// when all of jsinterop types are unreachable from main.
- if (!backend.compiler.resolverWorld.isImplemented(classElement)) return;
+ if (!backend.compiler.resolutionWorldBuilder.isImplemented(classElement))
Siggi Cherem (dart-lang) 2017/01/11 23:54:56 we might need to add {} here since it's no longer
Johnni Winther 2017/01/12 12:20:12 Done.
+ return;
if (!classElement.implementsInterface(helpers.jsJavaScriptObjectClass)) {
backend.reporter.reportErrorMessage(classElement,
@@ -166,7 +167,7 @@ class JsInteropAnalysis {
jsAst.Statement buildJsInteropBootstrap() {
if (!enabledJsInterop) return null;
List<jsAst.Statement> statements = <jsAst.Statement>[];
- backend.compiler.codegenWorld.forEachInvokedName(
+ backend.compiler.codegenWorldBuilder.forEachInvokedName(
(String name, Map<Selector, SelectorConstraints> selectors) {
selectors.forEach((Selector selector, SelectorConstraints constraints) {
if (selector.isClosureCall) {
@@ -189,7 +190,7 @@ class JsInteropAnalysis {
}
ResolutionFunctionType buildJsFunctionType() {
- // TODO(jacobr): consider using codegenWorld.isChecks to determine the
+ // TODO(jacobr): consider using codegenWorldBuilder.isChecks to determine the
// range of positional arguments that need to be supported by JavaScript
// function types.
return new ResolutionFunctionType.synthesized(

Powered by Google App Engine
This is Rietveld 408576698