chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java - Issue 2625703002: [MediaNotification] Don't check HTTP status code for image fetch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java

Issue 2625703002: [MediaNotification] Don't check HTTP status code for image fetch (Closed)

Patch Set: fixed junit test & cl format Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java ('k') | content/browser/web_contents/web_contents_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java

index c82cca311354e81b48af9fd7a9ab72c603c30c7a..3496e023200aa1904d9dd14d18c0cc7ab58afa2c 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java

@@ -177,7 +177,7 @@ public class MediaImageManagerTest {

public void testDownloadImageFails() {

mMediaImageManager.downloadImage(mImages, mCallback);

mMediaImageManager.onFinishDownloadImage(

- REQUEST_ID_1, 404, IMAGE_URL, mBitmaps, mOriginalImageSizes);

+ REQUEST_ID_1, 404, IMAGE_URL, new ArrayList<Bitmap>(), new ArrayList<Rect>());

verify(mCallback).onImageDownloaded(isNull(Bitmap.class));

verify(mCallback, times(0)).onImageDownloaded(isNotNull(Bitmap.class));