Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2625673003: Enable viewing render tests results on buildbot on Android FYI bot. (Closed)

Created:
3 years, 11 months ago by mikecase (-- gone --)
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable viewing render tests results on buildbot on Android FYI bot. Adding example test with render tests to FYI bot. If everything works as intended, will enable this on all bots. Will also switch implementation from needing to be configured by manually setting render_results_dir to detecting the render_results_dir automatically.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mikecase (-- gone --)
Just want to add a new test to the Android FYI bot with a new ...
3 years, 11 months ago (2017-01-10 17:18:19 UTC) #2
Dirk Pranke
I have no idea what this does :). Also, you have a typo in your ...
3 years, 11 months ago (2017-01-10 17:23:35 UTC) #3
mikecase (wrong mikecase)
fixed typo in desc
3 years, 11 months ago (2017-01-10 17:54:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625673003/1
3 years, 11 months ago (2017-01-10 17:55:20 UTC) #8
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-10 19:12:35 UTC) #11
mikecase (-- gone --)
Reverting since the FYI bot seems to be having trouble running chrome_public_test_apk (seems like device ...
3 years, 11 months ago (2017-01-12 20:33:07 UTC) #12
mikecase (-- gone --)
3 years, 11 months ago (2017-01-12 20:33:25 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2629523005/ by mikecase@chromium.org.

The reason for reverting is: Reverting since the FYI bot seems to be having
trouble running chrome_public_test_apk (seems like device or adb issue). Enabled
this on another bot (M tester on chromium.android)..

Powered by Google App Engine
This is Rietveld 408576698