Chromium Code Reviews Chromium Code Reviews
Issue 2625663003:
Layout nits for the signin email confirmation dialog. (Closed)
| OLD | NEW |
|---|---|
| 1 <!doctype html> | 1 <!doctype html> |
| 2 <html i18n-values="dir:textdirection;lang:language"> | 2 <html i18n-values="dir:textdirection;lang:language"> |
| 3 <head> | 3 <head> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <link rel="import" href="chrome://resources/html/polymer.html"> | 5 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper- button.html"> | 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper- button.html"> |
| 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/ paper-radio-button.html"> | 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/ paper-radio-button.html"> |
| 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-group/p aper-radio-group.html"> | 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-group/p aper-radio-group.html"> |
| 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color. html"> | 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color. html"> |
| 10 <link rel="import" href="signin_shared_css.html"> | 10 <link rel="import" href="signin_shared_css.html"> |
| 11 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css"> | 11 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css"> |
| 12 <link rel="import" href="chrome://resources/html/cr.html"> | 12 <link rel="import" href="chrome://resources/html/cr.html"> |
| 13 <link rel="import" href="chrome://resources/html/load_time_data.html"> | 13 <link rel="import" href="chrome://resources/html/load_time_data.html"> |
| 14 <link rel="import" href="chrome://resources/html/util.html"> | 14 <link rel="import" href="chrome://resources/html/util.html"> |
| 15 <style is="custom-style" include="signin-dialog-shared"> | 15 <style is="custom-style" include="signin-dialog-shared"> |
| 16 .details { | 16 .details { |
| 17 line-height: 20px; | 17 line-height: 20px; |
| 18 margin-bottom: 8px; | 18 padding: 8px 24px 0; |
| 19 margin-left: -8px; | 19 -webkit-margin-start: -8px; |
|
Dan Beam
2017/01/12 18:32:58
this should go at the top of this rule
msarda
2017/01/13 09:54:16
Done.
| |
| 20 padding: 0 24px; | 20 } |
| 21 | |
| 22 .container { | |
| 23 /* The sign-in confirmation dialog uses a width that is larger than | |
| 24 * the other sign-in dialogs to fit cases when the user has an email | |
| 25 * name that is very large. */ | |
| 26 width: 512px; | |
| 27 } | |
| 28 | |
| 29 .radio-button-title-container { | |
| 30 line-height: 20px; | |
| 31 } | |
| 32 | |
| 33 .top-title-bar { | |
| 34 color: #333; | |
| 35 | |
| 36 /* The signin email confirmation dialog needs to support cases when the | |
| 37 * title extends multiple lines. In that case, the height of the title | |
| 38 * bar is equal to padding + height of the text (which is equal to | |
| 39 * 2*16px + nb_lines * 22px). */ | |
| 40 line-height: 22px; | |
| 41 padding: 16px 24px; | |
| 42 height: auto; | |
|
Dan Beam
2017/01/12 18:32:58
please alphabetize these rules
msarda
2017/01/13 09:54:16
Done (I also alphabetize the classes).
| |
| 21 } | 43 } |
| 22 | 44 |
| 23 #closeButton { | 45 #closeButton { |
| 24 -webkit-margin-start: 8px; | 46 -webkit-margin-start: 8px; |
| 25 } | 47 } |
| 26 | 48 |
| 27 <if expr="is_macosx or is_linux"> | 49 <if expr="is_macosx or is_linux"> |
| 28 #closeButton { | 50 #closeButton { |
| 29 -webkit-margin-end: 8px; | 51 -webkit-margin-end: 8px; |
| 30 -webkit-margin-start: 0; | 52 -webkit-margin-start: 0; |
| 31 } | 53 } |
| 32 </if> | 54 </if> |
| 33 </style> | 55 </style> |
| 34 </head> | 56 </head> |
| 35 <body> | 57 <body> |
| 36 <div class="container"> | 58 <div class="container"> |
| 37 <div class="top-title-bar" id='dialogTitle'> | 59 <div class="top-title-bar" id='dialogTitle'> |
| 38 $i18n{signinEmailConfirmationTitle} | 60 $i18n{signinEmailConfirmationTitle} |
| 39 </div> | 61 </div> |
| 40 <div class="details"> | 62 <div class="details"> |
| 41 <paper-radio-group selected="createNewUser"> | 63 <paper-radio-group selected="createNewUser"> |
| 42 <paper-radio-button id="createNewUserRadioButton" | 64 <paper-radio-button id="createNewUserRadioButton" |
| 43 name="createNewUser"> | 65 name="createNewUser"> |
| 44 $i18n{signinEmailConfirmationCreateProfileButtonTitle} | 66 <div class="radio-button-title-container" |
| 67 id="createNewUserRadioButtonTitle"> | |
| 68 $i18n{signinEmailConfirmationCreateProfileButtonTitle} | |
| 69 </div> | |
| 45 </paper-radio-button> | 70 </paper-radio-button> |
| 46 <paper-radio-button id="startSyncRadioButton" name="startSync"> | 71 <paper-radio-button id="startSyncRadioButton" name="startSync"> |
| 47 $i18n{signinEmailConfirmationStartSyncButtonTitle} | 72 <div class="radio-button-title-container" |
| 73 id="startSyncRadioButtonTitle"> | |
| 74 $i18n{signinEmailConfirmationStartSyncButtonTitle} | |
| 75 </div> | |
| 48 </paper-radio-button> | 76 </paper-radio-button> |
| 49 </paper-radio-group> | 77 </paper-radio-group> |
| 50 </div> | 78 </div> |
| 51 <div class="action-container"> | 79 <div class="action-container"> |
| 52 <paper-button class="primary-action" id="confirmButton"> | 80 <paper-button class="primary-action" id="confirmButton"> |
| 53 $i18n{signinEmailConfirmationConfirmLabel} | 81 $i18n{signinEmailConfirmationConfirmLabel} |
| 54 </paper-button> | 82 </paper-button> |
| 55 <paper-button class="secondary-action" id="closeButton"> | 83 <paper-button class="secondary-action" id="closeButton"> |
| 56 $i18n{signinEmailConfirmationCloseLabel} | 84 $i18n{signinEmailConfirmationCloseLabel} |
| 57 </paper-button> | 85 </paper-button> |
| 58 </div> | 86 </div> |
| 59 </div> | 87 </div> |
| 60 </body> | 88 </body> |
| 61 <script src="signin_email_confirmation.js"></script> | 89 <script src="signin_email_confirmation.js"></script> |
| 62 <script src="chrome://signin-email-confirmation/strings.js"></script> | 90 <script src="chrome://signin-email-confirmation/strings.js"></script> |
| 63 </html> | 91 </html> |
| OLD | NEW |
