Chromium Code Reviews Chromium Code Reviews
Issue 2625663003:
Layout nits for the signin email confirmation dialog. (Closed)
| OLD | NEW |
|---|---|
| 1 <!doctype html> | 1 <!doctype html> |
| 2 <html i18n-values="dir:textdirection;lang:language"> | 2 <html i18n-values="dir:textdirection;lang:language"> |
| 3 <head> | 3 <head> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <link rel="import" href="chrome://resources/html/polymer.html"> | 5 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper- button.html"> | 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper- button.html"> |
| 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/ paper-radio-button.html"> | 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/ paper-radio-button.html"> |
| 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-group/p aper-radio-group.html"> | 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-group/p aper-radio-group.html"> |
| 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color. html"> | 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color. html"> |
| 10 <link rel="import" href="signin_shared_css.html"> | 10 <link rel="import" href="signin_shared_css.html"> |
| 11 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css"> | 11 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css"> |
| 12 <link rel="import" href="chrome://resources/html/cr.html"> | 12 <link rel="import" href="chrome://resources/html/cr.html"> |
| 13 <link rel="import" href="chrome://resources/html/load_time_data.html"> | 13 <link rel="import" href="chrome://resources/html/load_time_data.html"> |
| 14 <link rel="import" href="chrome://resources/html/util.html"> | 14 <link rel="import" href="chrome://resources/html/util.html"> |
| 15 <style is="custom-style" include="signin-dialog-shared"> | 15 <style is="custom-style" include="signin-dialog-shared"> |
| 16 .details { | 16 .details { |
| 17 line-height: 20px; | 17 line-height: 20px; |
| 18 margin-bottom: 8px; | 18 margin-bottom: 8px; |
| 19 margin-left: -8px; | 19 margin-left: -8px; |
| 20 padding: 0 24px; | 20 padding: 0 24px; |
| 21 } | 21 } |
| 22 | 22 |
| 23 .container { | |
| 24 /* The sign-in confirmation dialog uses a width that is larger than | |
| 25 the other sign-in dialogs to fit cases when the user has an email name | |
| 26 that is very large*/ | |
| 27 width: 512px; | |
| 28 } | |
| 29 | |
| 30 .top-title-bar { | |
| 31 color: #333; | |
| 32 | |
| 33 /* The signin email confirmation dialog needs to support cases when the | |
| 34 title extends multiple lines. In that case, the height of the title | |
| 35 bar is equal to padding + height of the text (which is equal to | |
| 36 2*16px + nb_lines * 22px). | |
| 37 */ | |
| 38 line-height: 22px; | |
| 39 padding: 16px 24px; | |
| 40 height: auto; | |
| 41 } | |
| 42 | |
| 23 #closeButton { | 43 #closeButton { |
| 24 -webkit-margin-start: 8px; | 44 -webkit-margin-start: 8px; |
| 25 } | 45 } |
| 26 | 46 |
| 27 <if expr="is_macosx or is_linux"> | 47 <if expr="is_macosx or is_linux"> |
| 28 #closeButton { | 48 #closeButton { |
| 29 -webkit-margin-end: 8px; | 49 -webkit-margin-end: 8px; |
| 30 -webkit-margin-start: 0; | 50 -webkit-margin-start: 0; |
| 31 } | 51 } |
| 32 </if> | 52 </if> |
| 33 </style> | 53 </style> |
| 34 </head> | 54 </head> |
| 35 <body> | 55 <body> |
| 36 <div class="container"> | 56 <div class="container"> |
| 37 <div class="top-title-bar" id='dialogTitle'> | 57 <div class="top-title-bar" id='dialogTitle'> |
| 38 $i18n{signinEmailConfirmationTitle} | 58 $i18n{signinEmailConfirmationTitle} |
| 39 </div> | 59 </div> |
| 40 <div class="details"> | 60 <div class="details"> |
| 41 <paper-radio-group selected="createNewUser"> | 61 <paper-radio-group selected="createNewUser"> |
| 42 <paper-radio-button id="createNewUserRadioButton" | 62 <paper-radio-button id="createNewUserRadioButton" |
| 43 name="createNewUser"> | 63 name="createNewUser"> |
| 44 $i18n{signinEmailConfirmationCreateProfileButtonTitle} | 64 $i18n{signinEmailConfirmationCreateProfileButtonTitle} |
|
Dan Beam
2017/01/10 18:35:16
if you wrap these $i18n{} in elements, you can con
| |
| 45 </paper-radio-button> | 65 </paper-radio-button> |
| 46 <paper-radio-button id="startSyncRadioButton" name="startSync"> | 66 <paper-radio-button id="startSyncRadioButton" name="startSync"> |
| 47 $i18n{signinEmailConfirmationStartSyncButtonTitle} | 67 $i18n{signinEmailConfirmationStartSyncButtonTitle} |
| 48 </paper-radio-button> | 68 </paper-radio-button> |
| 49 </paper-radio-group> | 69 </paper-radio-group> |
| 50 </div> | 70 </div> |
| 51 <div class="action-container"> | 71 <div class="action-container"> |
| 52 <paper-button class="primary-action" id="confirmButton"> | 72 <paper-button class="primary-action" id="confirmButton"> |
| 53 $i18n{signinEmailConfirmationConfirmLabel} | 73 $i18n{signinEmailConfirmationConfirmLabel} |
| 54 </paper-button> | 74 </paper-button> |
| 55 <paper-button class="secondary-action" id="closeButton"> | 75 <paper-button class="secondary-action" id="closeButton"> |
| 56 $i18n{signinEmailConfirmationCloseLabel} | 76 $i18n{signinEmailConfirmationCloseLabel} |
| 57 </paper-button> | 77 </paper-button> |
| 58 </div> | 78 </div> |
| 59 </div> | 79 </div> |
| 60 </body> | 80 </body> |
| 61 <script src="signin_email_confirmation.js"></script> | 81 <script src="signin_email_confirmation.js"></script> |
| 62 <script src="chrome://signin-email-confirmation/strings.js"></script> | 82 <script src="chrome://signin-email-confirmation/strings.js"></script> |
| 63 </html> | 83 </html> |
| OLD | NEW |
