Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2625633002: Supporting changes in preparation of browser side mixed content checking. (Closed)
Patch Set: Address code review comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index eba07da522c327c1ceb5d2da68d6918584214342..8ed60813cfc8592fe75bd843f6931c59c078c1ba 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -30,6 +30,7 @@
#include "content/public/common/url_constants.h"
#include "net/base/net_errors.h"
#include "net/url_request/redirect_info.h"
+#include "third_party/WebKit/public/platform/WebMixedContentContextType.h"
#include "url/gurl.h"
#include "url/url_constants.h"
@@ -92,6 +93,7 @@ NavigationHandleImpl::NavigationHandleImpl(
navigation_start_(navigation_start),
pending_nav_entry_id_(pending_nav_entry_id),
request_context_type_(REQUEST_CONTEXT_TYPE_UNSPECIFIED),
+ mixed_content_context_type_(blink::WebMixedContentContextType::Blockable),
should_replace_current_entry_(false),
is_download_(false),
is_stream_(false),
@@ -315,6 +317,7 @@ NavigationHandleImpl::CallWillStartRequestForTesting(
WillStartRequest(method, resource_request_body, sanitized_referrer,
has_user_gesture, transition, is_external_protocol,
REQUEST_CONTEXT_TYPE_LOCATION,
+ blink::WebMixedContentContextType::Blockable,
base::Bind(&UpdateThrottleCheckResult, &result));
// Reset the callback to ensure it will not be called later.
@@ -422,6 +425,7 @@ void NavigationHandleImpl::WillStartRequest(
ui::PageTransition transition,
bool is_external_protocol,
RequestContextType request_context_type,
+ blink::WebMixedContentContextType mixed_content_context_type,
const ThrottleChecksFinishedCallback& callback) {
if (method != "POST")
DCHECK(!resource_request_body);
@@ -435,6 +439,7 @@ void NavigationHandleImpl::WillStartRequest(
transition_ = transition;
is_external_protocol_ = is_external_protocol;
request_context_type_ = request_context_type;
+ mixed_content_context_type_ = mixed_content_context_type;
state_ = WILL_SEND_REQUEST;
complete_callback_ = callback;
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.h ('k') | content/browser/frame_host/navigation_handle_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698