Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2625533002: Add code to ProcessedOptions to fetch the SDK summary bundle. (Closed)

Created:
3 years, 11 months ago by Paul Berry
Modified:
3 years, 11 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add code to ProcessedOptions to fetch the SDK summary bundle. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/fdbdd8a4d8ece6b7fea6917fd116aa4325915b98

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -0 lines) Patch
M pkg/front_end/lib/src/base/processed_options.dart View 4 chunks +54 lines, -0 lines 2 comments Download
M pkg/front_end/test/src/base/processed_options_test.dart View 4 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 11 months ago (2017-01-09 21:54:06 UTC) #2
danrubel
LGTM with comment to do with as you choose. https://codereview.chromium.org/2625533002/diff/1/pkg/front_end/lib/src/base/processed_options.dart File pkg/front_end/lib/src/base/processed_options.dart (right): https://codereview.chromium.org/2625533002/diff/1/pkg/front_end/lib/src/base/processed_options.dart#newcode38 pkg/front_end/lib/src/base/processed_options.dart:38: ...
3 years, 11 months ago (2017-01-09 22:01:23 UTC) #3
Paul Berry
https://codereview.chromium.org/2625533002/diff/1/pkg/front_end/lib/src/base/processed_options.dart File pkg/front_end/lib/src/base/processed_options.dart (right): https://codereview.chromium.org/2625533002/diff/1/pkg/front_end/lib/src/base/processed_options.dart#newcode38 pkg/front_end/lib/src/base/processed_options.dart:38: Uri _sdkLocation; On 2017/01/09 22:01:23, danrubel wrote: > Is ...
3 years, 11 months ago (2017-01-11 14:12:45 UTC) #4
Paul Berry
3 years, 11 months ago (2017-01-11 14:19:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fdbdd8a4d8ece6b7fea6917fd116aa4325915b98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698