Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2625503002: GN: Add environment variables for sysroot, toolchain (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
Bill Hesse, Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Add environment variables for sysroot, toolchain Also accept a map instead of a single path for each so the toolchain/sysroot can be set per-arch. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/0962a0f6f5a96f9ab3a420a68d3ee755c7ba4d72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -25 lines) Patch
M tools/gn.py View 5 chunks +53 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zra
This should help with the GN mips cross-build.
3 years, 11 months ago (2017-01-09 20:23:35 UTC) #3
zra
3 years, 11 months ago (2017-01-09 21:36:17 UTC) #5
Cutch
lgtm
3 years, 11 months ago (2017-01-09 23:36:45 UTC) #6
zra
3 years, 11 months ago (2017-01-09 23:53:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0962a0f6f5a96f9ab3a420a68d3ee755c7ba4d72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698