Remove some CFX_ArrayTemplate in fpdfapi and fpdfdoc

core/fpdfdoc/cpdf_formfield.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfdoc/cpdf_formfield.h"
 
 #include <memory>
 #include <set>
@@ skipping 227 matching lines @@
       break;
     }
   }
   return true;
 }
 
 int CPDF_FormField::GetControlIndex(const CPDF_FormControl* pControl) const {
   if (!pControl)
     return -1;
 
-  for (int i = 0; i < m_ControlList.GetSize(); i++) {
-    if (m_ControlList.GetAt(i) == pControl)
-      return i;
-  }
-  return -1;
+  auto it = std::find(m_ControlList.begin(), m_ControlList.end(), pControl);
+  return it != m_ControlList.end() ? it - m_ControlList.begin() : -1;

[dsinclair, 2017/01/10 14:11:10]

What are your thoughts on std::tie? It would be nice (a some later point) to
stop returning invalid array indexes. We could do something like:

std::pair<bool, size_t> GetControlIndex(pControl) {
  if (!pControl) {
    return std::pair<bool, size>{false, 0};

  auto it = ...
  return std::pair<bool, size>{true, it - m_ControlList.begin() };
}

Then the callers can do something like:

bool found = false;
size_t idx = 0;
std::tie(found, idx) = GetControlIndex(control);

[Tom Sepez, 2017/01/10 18:06:27]

I really like this approach where there ain't no out parameters. Someday.  Not
sure if I prefer tie() or just 
auto result = GCI(control);
if (result.first) ...

 }
 
 int CPDF_FormField::GetFieldType() const {
   switch (m_Type) {
     case PushButton:
       return FIELDTYPE_PUSHBUTTON;
     case CheckBox:
       return FIELDTYPE_CHECKBOX;
     case RadioButton:
       return FIELDTYPE_RADIOBUTTON;
@@ skipping 144 matching lines @@
 }
 
 bool CPDF_FormField::SetValue(const CFX_WideString& value, bool bNotify) {
   return SetValue(value, false, bNotify);
 }
 
 int CPDF_FormField::GetMaxLen() const {
   if (CPDF_Object* pObj = FPDF_GetFieldAttr(m_pDict, "MaxLen"))
     return pObj->GetInteger();
 
-  for (int i = 0; i < m_ControlList.GetSize(); i++) {
-    CPDF_FormControl* pControl = m_ControlList.GetAt(i);
+  for (const CPDF_FormControl* pControl : m_ControlList) {

[dsinclair, 2017/01/10 14:11:11]

auto?

[Tom Sepez, 2017/01/10 18:06:27]

Done.

     if (!pControl)
       continue;
-
     CPDF_Dictionary* pWidgetDict = pControl->m_pWidgetDict;
     if (pWidgetDict->KeyExist("MaxLen"))
       return pWidgetDict->GetIntegerFor("MaxLen");
   }
   return 0;
 }
 
 int CPDF_FormField::CountSelectedItems() const {
   CPDF_Object* pValue = FPDF_GetFieldAttr(m_pDict, "V");
   if (!pValue) {
@@ skipping 552 matching lines @@
     case ListBox:
       NotifyAfterSelectionChange();
       break;
     case ComboBox:
       NotifyAfterValueChange();
       break;
     default:
       break;
   }
 }