Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: runtime/bin/eventhandler_fuchsia.cc

Issue 2625463002: Fuchsia: Remove overly-restrictive assert from eventhandler (Closed)
Patch Set: Format Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/eventhandler_fuchsia.cc
diff --git a/runtime/bin/eventhandler_fuchsia.cc b/runtime/bin/eventhandler_fuchsia.cc
index 39be1ffb423f340c45c3759604dd5d135e61d42a..667e9b05f3cdacb1db2a435e3c93f7e67fabd93c 100644
--- a/runtime/bin/eventhandler_fuchsia.cc
+++ b/runtime/bin/eventhandler_fuchsia.cc
@@ -327,7 +327,10 @@ void EventHandlerImplementation::HandleInterruptFd() {
delete di;
}
- DartUtils::PostInt32(port, 1 << kDestroyedEvent);
+ bool success = DartUtils::PostInt32(port, 1 << kDestroyedEvent);
+ if (!success) {
+ LOG_ERR("Failed to post destroy event to port %ld", port);
+ }
} else if (IS_COMMAND(msg[i].data, kReturnTokenCommand)) {
int count = TOKEN_COUNT(msg[i].data);
intptr_t old_mask = di->Mask();
@@ -404,7 +407,8 @@ void EventHandlerImplementation::HandleEvents(struct epoll_event* events,
if (!success) {
// This can happen if e.g. the isolate that owns the port has died
// for some reason.
- FATAL2("Failed to post event for fd %ld to port %ld", di->fd(), port);
+ LOG_ERR("Failed to post event for fd %ld to port %ld", di->fd(),
+ port);
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698