content/browser/android/content_view_core_impl.cc - Issue 262543002: android: add ThumbnailCache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 262543002: android: add ThumbnailCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@codec

Patch Set: renamed ThumbnailCacheCore to ThumbnailCache Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 60d1b85717e278f4d05470029196034cfeec5ba0..77bbaad919a4fccc03867981a28d7f68beecdcd2 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -675,7 +675,7 @@ void ContentViewCoreImpl::ShowPastePopup(int x_dip, int y_dip) {

void ContentViewCoreImpl::GetScaledContentBitmap(

float scale,

- jobject jbitmap_config,

+ SkBitmap::Config bitmap_config,

gfx::Rect src_subrect,

const base::Callback<void(bool, const SkBitmap&)>& result_callback) {

RenderWidgetHostViewAndroid* view = GetRenderWidgetHostViewAndroid();

@@ -683,8 +683,7 @@ void ContentViewCoreImpl::GetScaledContentBitmap(

result_callback.Run(false, SkBitmap());

return;

}

- SkBitmap::Config skbitmap_format = gfx::ConvertToSkiaConfig(jbitmap_config);

- view->GetScaledContentBitmap(scale, skbitmap_format, src_subrect,

+ view->GetScaledContentBitmap(scale, bitmap_config, src_subrect,

result_callback);

}