[ios] Fix settings switch accessibility value and hint

ios/chrome/browser/ui/settings/cells/sync_switch_item.mm

Index: ios/chrome/browser/ui/settings/cells/sync_switch_item.mm
diff --git a/ios/chrome/browser/ui/settings/cells/sync_switch_item.mm b/ios/chrome/browser/ui/settings/cells/sync_switch_item.mm
index e3d070cac15c8371fdcd1fa1d0b449572110e1c7..d8191ee5d6233d8f744a8c189d4d8594a1a5479c 100644
--- a/ios/chrome/browser/ui/settings/cells/sync_switch_item.mm
+++ b/ios/chrome/browser/ui/settings/cells/sync_switch_item.mm
@@ -5,8 +5,10 @@
 #import "ios/chrome/browser/ui/settings/cells/sync_switch_item.h"
 
 #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
+#include "ios/chrome/grit/ios_strings.h"
 #import "ios/third_party/material_components_ios/src/components/Palettes/src/MaterialPalettes.h"
 #import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
+#include "ui/base/l10n/l10n_util_mac.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
@@ -38,7 +40,6 @@ const CGFloat kHorizontalSwitchPadding = 10;
   if (self) {
     self.cellClass = [SyncSwitchCell class];
     self.enabled = YES;
-    self.accessibilityTraits |= UIAccessibilityTraitButton;
   }
   return self;
 }
@@ -96,6 +97,8 @@ const CGFloat kHorizontalSwitchPadding = 10;
     _switchView = [[UISwitch alloc] initWithFrame:CGRectZero];
     _switchView.translatesAutoresizingMaskIntoConstraints = NO;
     _switchView.onTintColor = [[MDCPalette cr_bluePalette] tint500];
+    _switchView.accessibilityHint = l10n_util::GetNSString(
+        IDS_IOS_TOGGLE_SETTING_SWITCH_ACCESSIBILITY_HINT);
     [self.contentView addSubview:_switchView];
 
     [self setConstraints];
@@ -179,7 +182,11 @@ const CGFloat kHorizontalSwitchPadding = 10;
 }
 
 - (NSString*)accessibilityHint {
-  return _switchView.accessibilityHint;
+  if (_switchView.isEnabled) {
+    return _switchView.accessibilityHint;

[edchin, 2017/01/12 22:13:45]

Should both the row and the switch have the same hint? 

[sczs, 2017/01/12 22:26:17]

Yes, we are aiming to imitate iOS settings switches. In this case only the row
is an accessible element, so only one hint is read.

[edchin, 2017/01/12 22:37:54]

Why not set the hint only on the row if it is the only accessible element?

[lpromero, 2017/01/13 10:01:33]

No action needed: If in the future we need to have a secondary element within
the cell, the row will stop being an accessibility element and will list its
children as elements. Sergio's approach seems more maintainable this way, where
the switch holds the info no matter what, and the row makes the connection,
based on the behavior it decides it wants.

+  } else {
+    return @"";
+  }
 }
 
 - (NSString*)accessibilityLabel {
@@ -191,7 +198,11 @@ const CGFloat kHorizontalSwitchPadding = 10;
 }
 
 - (NSString*)accessibilityValue {
-  return _switchView.accessibilityValue;
+  if (_switchView.on) {
+    return l10n_util::GetNSString(IDS_IOS_SETTING_ON);
+  } else {
+    return l10n_util::GetNSString(IDS_IOS_SETTING_OFF);
+  }
 }
 
 @end