Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: src/compiler-dispatcher/compiler-dispatcher.cc

Issue 2625413004: [compiler-dispatcher] make it so that we can always parse on bg threads (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler-dispatcher/compiler-dispatcher.cc
diff --git a/src/compiler-dispatcher/compiler-dispatcher.cc b/src/compiler-dispatcher/compiler-dispatcher.cc
index 2e7923bd928905dfaf8be560e8ff8d7557a12490..6549a5b908f8d533ffc7940827022b70207a6d70 100644
--- a/src/compiler-dispatcher/compiler-dispatcher.cc
+++ b/src/compiler-dispatcher/compiler-dispatcher.cc
@@ -68,10 +68,8 @@ bool IsFinished(CompilerDispatcherJob* job) {
}
bool CanRunOnAnyThread(CompilerDispatcherJob* job) {
- return (job->status() == CompileJobStatus::kReadyToParse &&
- job->can_parse_on_background_thread()) ||
- (job->status() == CompileJobStatus::kReadyToCompile &&
- job->can_compile_on_background_thread());
+ return (job->status() == CompileJobStatus::kReadyToParse) ||
vogelheim 2017/01/13 15:20:22 style nitpick: parentheses aren't really needed. S
jochen (gone - plz use gerrit) 2017/01/13 16:14:40 done
+ (job->status() == CompileJobStatus::kReadyToCompile);
rmcilroy 2017/01/13 15:56:22 This now implicitly assumes the compiler dispatche
jochen (gone - plz use gerrit) 2017/01/13 16:14:40 done
}
void DoNextStepOnBackgroundThread(CompilerDispatcherJob* job) {

Powered by Google App Engine
This is Rietveld 408576698