Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Side by Side Diff: cc/output/software_renderer.cc

Issue 2625403002: Prefer newly added SkPaint::refFoo() over getFoo() (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/software_renderer.h" 5 #include "cc/output/software_renderer.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/trace_event/trace_event.h" 8 #include "base/trace_event/trace_event.h"
9 #include "cc/base/math_util.h" 9 #include "cc/base/math_util.h"
10 #include "cc/output/copy_output_request.h" 10 #include "cc/output/copy_output_request.h"
(...skipping 529 matching lines...) Expand 10 before | Expand all | Expand 10 after
540 540
541 current_paint_.setRasterizer(builder.detach()); 541 current_paint_.setRasterizer(builder.detach());
542 } 542 }
543 543
544 // If we have a background filter shader, render its results first. 544 // If we have a background filter shader, render its results first.
545 sk_sp<SkShader> background_filter_shader = 545 sk_sp<SkShader> background_filter_shader =
546 GetBackgroundFilterShader(frame, quad, SkShader::kClamp_TileMode); 546 GetBackgroundFilterShader(frame, quad, SkShader::kClamp_TileMode);
547 if (background_filter_shader) { 547 if (background_filter_shader) {
548 SkPaint paint; 548 SkPaint paint;
549 paint.setShader(std::move(background_filter_shader)); 549 paint.setShader(std::move(background_filter_shader));
550 paint.setRasterizer(sk_ref_sp(current_paint_.getRasterizer())); 550 paint.setRasterizer(current_paint_.refRasterizer());
551 current_canvas_->drawRect(dest_visible_rect, paint); 551 current_canvas_->drawRect(dest_visible_rect, paint);
552 } 552 }
553 current_paint_.setShader(std::move(shader)); 553 current_paint_.setShader(std::move(shader));
554 current_canvas_->drawRect(dest_visible_rect, current_paint_); 554 current_canvas_->drawRect(dest_visible_rect, current_paint_);
555 } 555 }
556 556
557 void SoftwareRenderer::DrawUnsupportedQuad(const DrawingFrame* frame, 557 void SoftwareRenderer::DrawUnsupportedQuad(const DrawingFrame* frame,
558 const DrawQuad* quad) { 558 const DrawQuad* quad) {
559 #ifdef NDEBUG 559 #ifdef NDEBUG
560 current_paint_.setColor(SK_ColorWHITE); 560 current_paint_.setColor(SK_ColorWHITE);
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 ApplyImageFilter(filter.get(), quad, backdrop_bitmap, nullptr); 721 ApplyImageFilter(filter.get(), quad, backdrop_bitmap, nullptr);
722 722
723 if (!filter_backdrop_image) 723 if (!filter_backdrop_image)
724 return nullptr; 724 return nullptr;
725 725
726 return filter_backdrop_image->makeShader(content_tile_mode, content_tile_mode, 726 return filter_backdrop_image->makeShader(content_tile_mode, content_tile_mode,
727 &filter_backdrop_transform); 727 &filter_backdrop_transform);
728 } 728 }
729 729
730 } // namespace cc 730 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698