Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Side by Side Diff: test/mjsunit/es6/debug-promises-uncaught-uncaught.js

Issue 262533009: Revert "Trigger exception debug event for promises at the throw site." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --harmony-promises --expose-debug-as debug 5 // Flags: --harmony-promises --expose-debug-as debug
6 6
7 // Test debug events when we only listen to uncaught exceptions and 7 // Test debug events when we only listen to uncaught exceptions and
8 // there is a catch handler for the exception thrown in a Promise. 8 // there is a catch handler for the exception thrown in a Promise.
9 // We expect an Exception debug event with a promise to be triggered. 9 // Expectation:
10 // - only the PendingExceptionInPromise debug event is triggered.
10 11
11 Debug = debug.Debug; 12 Debug = debug.Debug;
12 13
13 var log = []; 14 var log = [];
14 var step = 0; 15 var step = 0;
15 16
16 var p = new Promise(function(resolve, reject) { 17 var p = new Promise(function(resolve, reject) {
17 log.push("resolve"); 18 log.push("resolve");
18 resolve(); 19 resolve();
19 }); 20 });
20 21
21 var q = p.chain( 22 var q = p.chain(
22 function() { 23 function() {
23 log.push("throw"); 24 log.push("throw");
24 throw new Error("uncaught"); // event 25 throw new Error("uncaught");
25 }); 26 });
26 27
27 function listener(event, exec_state, event_data, data) { 28 function listener(event, exec_state, event_data, data) {
28 try { 29 try {
29 // Ignore exceptions during startup in stress runs. 30 // Ignore exceptions during startup in stress runs.
30 if (step >= 1) return; 31 if (step >= 1) return;
31 assertEquals(["resolve", "end main", "throw"], log); 32 assertEquals(["resolve", "end main", "throw"], log);
32 if (event == Debug.DebugEvent.Exception) { 33 if (event == Debug.DebugEvent.Exception) {
34 assertUnreachable();
35 } else if (event == Debug.DebugEvent.PendingExceptionInPromise) {
33 assertEquals(0, step); 36 assertEquals(0, step);
34 assertEquals("uncaught", event_data.exception().message); 37 assertEquals("uncaught", event_data.exception().message);
35 assertTrue(event_data.promise() instanceof Promise); 38 assertTrue(event_data.promise() instanceof Promise);
36 assertEquals(q, event_data.promise());
37 assertTrue(event_data.uncaught()); 39 assertTrue(event_data.uncaught());
38 // Assert that the debug event is triggered at the throw site.
39 assertTrue(exec_state.frame(0).sourceLineText().indexOf("// event") > 0);
40 step++; 40 step++;
41 } 41 }
42 } catch (e) { 42 } catch (e) {
43 // Signal a failure with exit code 1. This is necessary since the 43 // Signal a failure with exit code 1. This is necessary since the
44 // debugger swallows exceptions and we expect the chained function 44 // debugger swallows exceptions and we expect the chained function
45 // and this listener to be executed after the main script is finished. 45 // and this listener to be executed after the main script is finished.
46 print("Unexpected exception: " + e + "\n" + e.stack); 46 print("Unexpected exception: " + e + "\n" + e.stack);
47 quit(1); 47 quit(1);
48 } 48 }
49 } 49 }
50 50
51 Debug.setBreakOnUncaughtException(); 51 Debug.setBreakOnUncaughtException();
52 Debug.setListener(listener); 52 Debug.setListener(listener);
53 53
54 log.push("end main"); 54 log.push("end main");
OLDNEW
« no previous file with comments | « test/mjsunit/es6/debug-promises-uncaught-all.js ('k') | test/mjsunit/es6/debug-promises-undefined-reject.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698