Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: test/mjsunit/es6/debug-promises-uncaught-all.js

Issue 262533009: Revert "Trigger exception debug event for promises at the throw site." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --harmony-promises --expose-debug-as debug 5 // Flags: --harmony-promises --expose-debug-as debug
6 6
7 // Test debug events when we listen to all exceptions and 7 // Test debug events when we listen to all exceptions and
8 // there is a catch handler for the exception thrown in a Promise. 8 // there is a catch handler for the exception thrown in a Promise.
9 // We expect an Exception debug event with a promise to be triggered. 9 // Expectation:
10 // - the normal Exception debug event is triggered.
11 // - the PendingExceptionInPromise debug event is triggered afterwards,
12 // with the same exception object.
10 13
11 Debug = debug.Debug; 14 Debug = debug.Debug;
12 15
13 var log = []; 16 var log = [];
14 var step = 0; 17 var step = 0;
15 var exception = undefined; 18 var exception = undefined;
16 19
17 var p = new Promise(function(resolve, reject) { 20 var p = new Promise(function(resolve, reject) {
18 log.push("resolve"); 21 log.push("resolve");
19 resolve(); 22 resolve();
20 }); 23 });
21 24
22 var q = p.chain( 25 var q = p.chain(
23 function() { 26 function() {
24 log.push("throw"); 27 log.push("throw");
25 throw new Error("uncaught"); // event 28 throw new Error("uncaught");
26 }); 29 });
27 30
28 function listener(event, exec_state, event_data, data) { 31 function listener(event, exec_state, event_data, data) {
29 try { 32 try {
30 // Ignore exceptions during startup in stress runs. 33 // Ignore exceptions during startup in stress runs.
31 if (step >= 1) return; 34 if (step > 1) return;
32 assertEquals(["resolve", "end main", "throw"], log); 35 assertEquals(["resolve", "end main", "throw"], log);
33 if (event == Debug.DebugEvent.Exception) { 36 if (event == Debug.DebugEvent.Exception) {
34 assertEquals(0, step); 37 assertEquals(0, step);
35 assertEquals("uncaught", event_data.exception().message); 38 exception = event_data.exception();
39 assertEquals(undefined, event_data.promise());
40 } else if (event == Debug.DebugEvent.PendingExceptionInPromise) {
41 assertEquals(1, step);
42 assertEquals(exception, event_data.exception());
43 assertEquals("uncaught", exception.message);
36 assertTrue(event_data.promise() instanceof Promise); 44 assertTrue(event_data.promise() instanceof Promise);
37 assertEquals(q, event_data.promise());
38 assertTrue(event_data.uncaught()); 45 assertTrue(event_data.uncaught());
39 // Assert that the debug event is triggered at the throw site. 46 } else {
40 assertTrue(exec_state.frame(0).sourceLineText().indexOf("// event") > 0); 47 return;
41 step++;
42 } 48 }
49 step++;
43 } catch (e) { 50 } catch (e) {
44 // Signal a failure with exit code 1. This is necessary since the 51 // Signal a failure with exit code 1. This is necessary since the
45 // debugger swallows exceptions and we expect the chained function 52 // debugger swallows exceptions and we expect the chained function
46 // and this listener to be executed after the main script is finished. 53 // and this listener to be executed after the main script is finished.
47 print("Unexpected exception: " + e + "\n" + e.stack); 54 print("Unexpected exception: " + e + "\n" + e.stack);
48 quit(1); 55 quit(1);
49 } 56 }
50 } 57 }
51 58
52 Debug.setBreakOnException(); 59 Debug.setBreakOnException();
53 Debug.setListener(listener); 60 Debug.setListener(listener);
54 61
55 log.push("end main"); 62 log.push("end main");
OLDNEW
« no previous file with comments | « test/mjsunit/es6/debug-promises-throw-in-reject.js ('k') | test/mjsunit/es6/debug-promises-uncaught-uncaught.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698