Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: test/mjsunit/es6/debug-promises-caught-uncaught.js

Issue 262533009: Revert "Trigger exception debug event for promises at the throw site." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --harmony-promises --expose-debug-as debug 5 // Flags: --harmony-promises --expose-debug-as debug
6 6
7 // Test debug events when we only listen to uncaught exceptions and 7 // Test debug events when we only listen to uncaught exceptions and
8 // there is a catch handler for the exception thrown in a Promise. 8 // there is a catch handler for the exception thrown in a Promise.
9 // We expect no debug event to be triggered. 9 // Expectation:
10 // - no debug event is triggered.
10 11
11 Debug = debug.Debug; 12 Debug = debug.Debug;
12 13
13 var p = new Promise(function(resolve, reject) { 14 var p = new Promise(function(resolve, reject) {
14 resolve(); 15 resolve();
15 }); 16 });
16 17
17 var q = p.chain( 18 var q = p.chain(
18 function() { 19 function() {
19 throw new Error("caught"); 20 throw new Error("caught");
20 }); 21 });
21 22
22 q.catch( 23 q.catch(
23 function(e) { 24 function(e) {
24 assertEquals("caught", e.message); 25 assertEquals("caught", e.message);
25 }); 26 });
26 27
27 function listener(event, exec_state, event_data, data) { 28 function listener(event, exec_state, event_data, data) {
28 try { 29 try {
29 assertTrue(event != Debug.DebugEvent.Exception); 30 assertTrue(event != Debug.DebugEvent.Exception);
31 assertTrue(event != Debug.DebugEvent.PendingExceptionInPromise);
30 } catch (e) { 32 } catch (e) {
31 // Signal a failure with exit code 1. This is necessary since the 33 // Signal a failure with exit code 1. This is necessary since the
32 // debugger swallows exceptions and we expect the chained function 34 // debugger swallows exceptions and we expect the chained function
33 // and this listener to be executed after the main script is finished. 35 // and this listener to be executed after the main script is finished.
34 print("Unexpected exception: " + e + "\n" + e.stack); 36 print("Unexpected exception: " + e + "\n" + e.stack);
35 quit(1); 37 quit(1);
36 } 38 }
37 } 39 }
38 40
39 Debug.setBreakOnUncaughtException(); 41 Debug.setBreakOnUncaughtException();
40 Debug.setListener(listener); 42 Debug.setListener(listener);
OLDNEW
« no previous file with comments | « test/mjsunit/es6/debug-promises-caught-late.js ('k') | test/mjsunit/es6/debug-promises-throw-in-constructor.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698