Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: test/mjsunit/es6/debug-promises-caught-all.js

Issue 262533009: Revert "Trigger exception debug event for promises at the throw site." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/runtime.cc ('k') | test/mjsunit/es6/debug-promises-caught-late.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --harmony-promises --expose-debug-as debug 5 // Flags: --harmony-promises --expose-debug-as debug
6 6
7 // Test debug events when we listen to all exceptions and 7 // Test debug events when we listen to all exceptions and
8 // there is a catch handler for the exception thrown in a Promise. 8 // there is a catch handler for the exception thrown in a Promise.
9 // We expect a normal Exception debug event to be triggered. 9 // Expectation:
10 // - only the normal Exception debug event is triggered.
10 11
11 Debug = debug.Debug; 12 Debug = debug.Debug;
12 13
13 var log = []; 14 var log = [];
14 var step = 0; 15 var step = 0;
15 16
16 var p = new Promise(function(resolve, reject) { 17 var p = new Promise(function(resolve, reject) {
17 log.push("resolve"); 18 log.push("resolve");
18 resolve(); 19 resolve();
19 }); 20 });
20 21
21 var q = p.chain( 22 var q = p.chain(
22 function() { 23 function() {
23 log.push("throw"); 24 log.push("throw");
24 throw new Error("caught"); 25 throw new Error("caught");
25 }); 26 });
26 27
27 q.catch( 28 q.catch(
28 function(e) { 29 function(e) {
29 assertEquals("caught", e.message); 30 assertEquals("caught", e.message);
30 }); 31 });
31 32
32 function listener(event, exec_state, event_data, data) { 33 function listener(event, exec_state, event_data, data) {
33 try { 34 try {
34 // Ignore exceptions during startup in stress runs. 35 // Ignore exceptions during startup in stress runs.
35 if (step >= 1) return; 36 if (step >= 1) return;
36 assertEquals(["resolve", "end main", "throw"], log); 37 assertEquals(["resolve", "end main", "throw"], log);
38 assertTrue(event != Debug.DebugEvent.PendingExceptionInPromise);
37 if (event == Debug.DebugEvent.Exception) { 39 if (event == Debug.DebugEvent.Exception) {
38 assertEquals("caught", event_data.exception().message); 40 assertEquals("caught", event_data.exception().message);
39 assertEquals(undefined, event_data.promise()); 41 assertEquals(undefined, event_data.promise());
40 assertFalse(event_data.uncaught());
41 step++; 42 step++;
42 } 43 }
43 } catch (e) { 44 } catch (e) {
44 // Signal a failure with exit code 1. This is necessary since the 45 // Signal a failure with exit code 1. This is necessary since the
45 // debugger swallows exceptions and we expect the chained function 46 // debugger swallows exceptions and we expect the chained function
46 // and this listener to be executed after the main script is finished. 47 // and this listener to be executed after the main script is finished.
47 print("Unexpected exception: " + e + "\n" + e.stack); 48 print("Unexpected exception: " + e + "\n" + e.stack);
48 quit(1); 49 quit(1);
49 } 50 }
50 } 51 }
51 52
52 Debug.setBreakOnException(); 53 Debug.setBreakOnException();
53 Debug.setListener(listener); 54 Debug.setListener(listener);
54 55
55 log.push("end main"); 56 log.push("end main");
OLDNEW
« no previous file with comments | « src/runtime.cc ('k') | test/mjsunit/es6/debug-promises-caught-late.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698