Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 262533006: ARM64: use jssp for stack slots (Closed)

Created:
6 years, 7 months ago by vincent.belliard
Modified:
5 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM64: use jssp for stack slots R=ulan@chromium.org, bmeurer@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -5 lines) Patch
M src/arm64/lithium-codegen-arm64.h View 3 chunks +19 lines, -2 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 11 chunks +41 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vincent.belliard
Access stack slots via jssp instead of fp when it's possible and needed. The aim ...
6 years, 7 months ago (2014-04-30 11:00:43 UTC) #1
Benedikt Meurer
LGTM
6 years, 7 months ago (2014-04-30 17:22:57 UTC) #2
Toon Verwaest
5 years, 9 months ago (2015-03-23 14:17:24 UTC) #4
Message was sent while issue was closed.
As far as I can tell this is broken. See
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4101
for a repro.

The reason why it is failing is that GenerateCallFunction pushes arguments a
single time, before branching on the function to choose the correct HInstruction
to use for the call. Given that there are 2 call instructions for the single
push (HInvokeFunction and HCallFunction) we think we're not in the push-case
anymore in DoInvokeFunction. DoCallFunction already reset after_push_argument_
to false. This causes us to load the value relative to the stack pointer at an
incorrect offset.

Powered by Google App Engine
This is Rietveld 408576698