Issue 26253003: Fix for blinking/corrupted text in Canvas 2D.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26253003: Fix for blinking/corrupted text in Canvas 2D. (Closed)

Created:
7 years, 2 months ago by jvanverth1

Modified:
7 years, 2 months ago

Reviewers:
bsalomon, Justin Novosad

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix for blinking/corrupted text in Canvas 2D. Ensure that we update the drawToken for a glyph's plot every time it is used, not just when the glyph is first added. BUG=303803 Committed: http://code.google.com/p/skia/source/detail?r=11637

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -12 lines)			Patch
M	src/gpu/GrTextContext.cpp	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	src/gpu/GrTextStrike.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrTextStrike.cpp	View	3 chunks	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm. The code appears to be simpler after this change as well as more correct.

7 years, 2 months ago (2013-10-07 17:40:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/26253003/1

7 years, 2 months ago (2013-10-07 18:13:42 UTC) #3

Message was sent while issue was closed.

Change committed as 11637

Expand Messages | Collapse Messages