WebUI: Add cr_policy_network_indicator_tests.js

chrome/test/data/webui/cr_elements/cr_policy_network_indicator_tests.js

Index: chrome/test/data/webui/cr_elements/cr_policy_network_indicator_tests.js
diff --git a/chrome/test/data/webui/cr_elements/cr_policy_network_indicator_tests.js b/chrome/test/data/webui/cr_elements/cr_policy_network_indicator_tests.js
new file mode 100644
index 0000000000000000000000000000000000000000..85e573aae67e01e74c764bbbc1491c9b4419ad04
--- /dev/null
+++ b/chrome/test/data/webui/cr_elements/cr_policy_network_indicator_tests.js
@@ -0,0 +1,88 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/** @fileoverview Suite of tests for cr_policy-network-indicator. */
+cr.define('cr_policy_network_indicator', function() {
+  function registerTests() {

[Dan Beam, 2017/01/12 18:18:18]

can you just drop these 2 lines? pretty much all new tests don't do this

[stevenjb, 2017/01/12 18:41:31]

Done.

+    suite('cr-policy-network-indicator', function() {
+      /** @type {!CrPolicyNetworkIndicatorElement|undefined} */
+      var indicator;
+
+      /** @type {!PaperTooltipElement|undefined} */
+      var tooltip;
+
+      setup(function() {
+        PolymerTest.clearBody();
+
+        CrPolicyStrings = {
+          controlledSettingPolicy: 'policy',
+          controlledSettingRecommendedMatches: 'matches',
+          controlledSettingRecommendedDiffers: 'differs',
+          controlledSettingShared: 'shared: $1',
+          controlledSettingOwner: 'owner: $1',
+        };
+
+        indicator = document.createElement('cr-policy-network-indicator');
+        document.body.appendChild(indicator);
+        tooltip = indicator.$$('paper-tooltip');
+      });
+
+      test('none', function() {

[Dan Beam, 2017/01/12 18:18:18]

can we name this 'hidden by default' or something slightly more descriptive?

[stevenjb, 2017/01/12 18:41:31]

Done.

+        assertTrue(indicator.$.indicator.hidden);

[Dan Beam, 2017/01/12 18:18:18]

can you create an accessor to this.$.indicator or specific attributes like
.hidden and .icon

this.$.* is basically internal state, and tests should strive to test public
state where possible. this makes refactoring easier and tests less brittle.

[stevenjb, 2017/01/12 18:41:31]

Apologies for being dense, but I don't quite follow, can you give me an example?
Would $$('#indicator') be better, or would you like to see that pattern removed
also? 

[Dan Beam, 2017/01/18 01:57:57]

Polymer({
  is: '...',
  get icon() {
    return this.$.indicator.icon;
  },
  get indicatorVisible() {
    return !this.$.indicator.hidden;
  },
})

+      });
+
+      test('no policy', function() {
+        indicator.property = {Active: 'foo'};
+        Polymer.dom.flush();
+        assertTrue(indicator.$.indicator.hidden);
+      });
+
+      test('recommended', function() {
+        indicator.property = {
+          Active: 'foo',
+          UserPolicy: 'bar',
+          UserEditable: true,
+          Effective: 'UserPolicy',
+        };
+        Polymer.dom.flush();
+        assertFalse(indicator.$.indicator.hidden);
+        assertEquals('cr:domain', indicator.$.indicator.icon);
+        assertEquals('differs', tooltip.textContent.trim());
+
+        indicator.set('property.Active', 'bar');
+        Polymer.dom.flush();
+        assertEquals('matches', tooltip.textContent.trim());
+      });
+
+      test('policy', function() {
+        indicator.property = {
+          DevicePolicy: 'foo',
+          Effective: 'DevicePolicy',
+        };
+        Polymer.dom.flush();
+        assertFalse(indicator.$.indicator.hidden);
+        assertEquals('cr:domain', indicator.$.indicator.icon);
+        assertEquals('policy', tooltip.textContent.trim());
+      });
+
+      test('extension', function() {
+        indicator.property = {
+          Active: 'foo',
+          Effective: 'ActiveExtension',
+        };
+        Polymer.dom.flush();
+        // Extension controlled properties do not have an indicator.
+        assertTrue(indicator.$.indicator.hidden);
+      });
+    });
+
+    suiteTeardown(function() {
+      PolymerTest.clearBody();  // crbug.com/680169
+    });
+  }
+
+  return {
+    registerTests: registerTests,
+  };
+});