Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2625163002: DevTools: don't cherrypick Common files for Gonzales (Closed)

Created:
3 years, 11 months ago by chenwilliam
Modified:
3 years, 11 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: don't cherrypick Common files for Gonzales Previous, Gonzales was cherrypicking files from Common module for the TextRange class which was used as a struct. BUG=none

Patch Set 1 #

Patch Set 2 : fmt + es6 #

Patch Set 3 : fmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -201 lines) Patch
M third_party/WebKit/Source/devtools/.eslintignore View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/module.json View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js View 1 2 1 chunk +205 lines, -198 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
chenwilliam
Because the gonzales folder is eslintignored, it didn't get formatted in the original sweep. Do ...
3 years, 11 months ago (2017-01-11 19:59:25 UTC) #2
pfeldman
On 2017/01/11 19:59:25, chenwilliam wrote: > Because the gonzales folder is eslintignored, it didn't get ...
3 years, 11 months ago (2017-01-11 21:05:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625163002/40001
3 years, 11 months ago (2017-01-11 23:46:46 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 04:05:37 UTC) #11
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

Powered by Google App Engine
This is Rietveld 408576698