Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2625133003: Handle geometry effects of filters in GeometryMapper (Closed)
Patch Set: Rebaseline tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
index 804bd9e5952f157c54a18bd20b961a10572a52e0..c765f11a7cbb4ee118a850e9d3e85a0303b154d6 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
@@ -527,7 +527,7 @@ void PaintPropertyTreeBuilder::updateEffect(
context.forceSubtreeUpdate |= properties.updateEffect(
context.currentEffect, context.current.transform, outputClip,
std::move(filter), opacity, blendMode, compositingReasons,
- compositorElementId);
+ compositorElementId, FloatPoint(context.current.paintOffset));
} else {
if (auto* properties = object.getMutableForPainting().paintProperties())
context.forceSubtreeUpdate |= properties->clearEffect();
@@ -965,8 +965,7 @@ void PaintPropertyTreeBuilder::updatePropertiesForSelf(
if (object.isBoxModelObject() || object.isSVG()) {
updatePaintOffsetTranslation(object, context);
updateTransform(object, context);
- if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
- updateEffect(object, context);
+ updateEffect(object, context);
updateCssClip(object, context);
updateLocalBorderBoxContext(object, context);
if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())

Powered by Google App Engine
This is Rietveld 408576698