Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 2625093002: [wrapper-tracing] Add heap snapshot generator infrastructure (Closed)
Patch Set: Fix leftover Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
index e6e7ce8ed3835089017642f63ae9bedf72b2b30e..585a81d1bc6200b3163665c515b29ea48f07afc8 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
@@ -397,4 +397,14 @@ void V8PerIsolateData::addActiveScriptWrappable(
m_activeScriptWrappables->add(wrappable);
}
+void V8PerIsolateData::TemporaryScriptWrappableVisitorScope::swapInNewVisitor(
+ ScriptWrappableVisitor* visitor) {
+ ScriptWrappableVisitor* current = currentVisitor(m_isolate);
+ if (current)
+ current->performCleanup();
+ V8PerIsolateData::from(m_isolate)->m_scriptWrappableVisitor.release();
haraken 2017/01/12 16:25:17 Do we need .release? Won't .reset() be enough?
Michael Lippautz 2017/01/13 15:08:40 Yeah we need release, as the visitors used through
+ V8PerIsolateData::from(m_isolate)->m_scriptWrappableVisitor.reset(visitor);
+ m_isolate->SetEmbedderHeapTracer(visitor);
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698