third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp - Issue 2625093002: [wrapper-tracing] Add heap snapshot generator infrastructure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2625093002: [wrapper-tracing] Add heap snapshot generator infrastructure (Closed)

Patch Set: Addressed comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

index b49db8f4544d9fcc501eebe93b9c73c89e957656..5608ebd9190e031836b6ceb40dcc22e5c968c4cf 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

@@ -417,9 +417,11 @@ void V8Initializer::initializeMainThread() {

isolate->SetPromiseRejectCallback(promiseRejectHandlerInMainThread);

- if (v8::HeapProfiler* profiler = isolate->GetHeapProfiler())

+ if (v8::HeapProfiler* profiler = isolate->GetHeapProfiler()) {

profiler->SetWrapperClassInfoProvider(

WrapperTypeInfo::NodeClassId, &RetainedDOMInfo::createRetainedDOMInfo);

+ profiler->SetGetRetainerInfosCallback(&V8GCController::getRetainerInfos);

+ }

ASSERT(ThreadState::mainThreadState());

ThreadState::mainThreadState()->addInterruptor(