[wrapper-tracing] Add heap snapshot generator infrastructure

third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 379 matching lines @@
 }
 
 void V8PerIsolateData::addActiveScriptWrappable(
     ActiveScriptWrappableBase* wrappable) {
   if (!m_activeScriptWrappables)
     m_activeScriptWrappables = new ActiveScriptWrappableSet();
 
   m_activeScriptWrappables->add(wrappable);
 }
 
+void V8PerIsolateData::TemporaryScriptWrappableVisitorScope::setVisitor(
+    ScriptWrappableVisitor* visitor) {
+  ScriptWrappableVisitor* current = currentVisitor(m_isolate);
+  if (current)
+    current->performCleanup();

[haraken, 2017/01/16 02:46:56]

Would you elaborate on why it's okay to call performCleanup()? Isn't it possible
that the current visitor is popped again later and tries to continue the
incremental tracing?

[Michael Lippautz, 2017/01/16 10:45:06]

We can only swap tracers when tracing is not yet started. Not started still
could mean that we have a pending cleanup task. performCleanup() conditionally
cleans up the tracer.

I added a CHECK to performCleanup that we are not in tracing mode.

[haraken, 2017/01/17 00:31:25]

How is it guaranteed that V8GCController::getRetainerInfos is called when the
tracing is not yet started? Does V8 guarantee the fact?

[Michael Lippautz, 2017/01/17 09:15:32]

Yes, V8 guarantees that.

+  V8PerIsolateData::from(m_isolate)->m_scriptWrappableVisitor.release();

[haraken, 2017/01/16 02:46:56]

Ah, you need .release() because you need to leak the pointer -- which looks a
bit nasty.

Can we make TemporaryScriptWrappableVisitorScope::m_savedVisitor a
std::unique_ptr<ScriptWrappableVisitor>? Then you can just pass an ownership to
m_savedVisitor instead of leaking.

[Michael Lippautz, 2017/01/16 10:45:06]

Ah, now I understand, thanks! Done.

+  V8PerIsolateData::from(m_isolate)->m_scriptWrappableVisitor.reset(visitor);
+  m_isolate->SetEmbedderHeapTracer(visitor);
+}
+
 }  // namespace blink