[Predator] Add MetaWeight and MetaFeatureValue to group multiple weights and features together.

appengine/findit/crash/loglinear/test/changelist_classifier_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import logging
 import math
 import pprint
 
 from common.dependency import Dependency
 from common.dependency import DependencyRoll
 from common.chrome_dependency_fetcher import ChromeDependencyFetcher
 import crash.changelist_classifier as scorer_changelist_classifier
 from crash.crash_report import CrashReport
 from crash.loglinear.changelist_classifier import LogLinearChangelistClassifier
+from crash.loglinear.changelist_features.min_distance import MinDistanceFeature
+from crash.loglinear.changelist_features.top_frame_index import (
+    TopFrameIndexFeature)
+from crash.loglinear.feature import WrapperMetaFeature
+from crash.loglinear.weight import Weight
+from crash.loglinear.weight import MetaWeight
 from crash.suspect import AnalysisInfo
 from crash.suspect import Suspect
 from crash.suspect import StackInfo
 from crash.stacktrace import CallStack
 from crash.stacktrace import StackFrame
 from crash.stacktrace import Stacktrace
 from crash.test.crash_test_suite import CrashTestSuite
 from crash.type_enums import CallStackFormatType
 from crash.type_enums import LanguageType
 from libs.gitiles.change_log import ChangeLog
@@ skipping 87 matching lines @@
     CallStack(1, [], CallStackFormatType.DEFAULT, LanguageType.CPP)]
 DUMMY_REPORT = CrashReport(
     None, None, None, Stacktrace(DUMMY_CALLSTACKS, DUMMY_CALLSTACKS[0]),
     (None, None))
 
 
 class LogLinearChangelistClassifierTest(CrashTestSuite):
 
   def setUp(self):
     super(LogLinearChangelistClassifierTest, self).setUp()
-    weights = {
-        'MinDistance': 1.,
-        'TopFrameIndex': 1.,
-    }
+    meta_weight = MetaWeight({
+        'MinDistance': Weight(1.),
+        'TopFrameIndex': Weight(1.),
+    })
+    meta_feature = WrapperMetaFeature([MinDistanceFeature(),
+                                       TopFrameIndexFeature()])
 
     self.changelist_classifier = LogLinearChangelistClassifier(
-        GitilesRepository.Factory(self.GetMockHttpClient()), weights)
+        GitilesRepository.Factory(self.GetMockHttpClient()),
+        meta_feature, meta_weight)
 
   # TODO(http://crbug.com/659346): why do these mocks give coverage
   # failures? That's almost surely hiding a bug in the tests themselves.
   def testFindItForCrashNoRegressionRange(self): # pragma: no cover
     self.mock(ChromeDependencyFetcher, 'GetDependencyRollsDict', lambda *_: {})
     self.mock(ChromeDependencyFetcher, 'GetDependency', lambda *_: {})
     # N.B., for this one test we really do want regression_range=None.
     report = DUMMY_REPORT._replace(regression_range=None)
     self.assertListEqual(self.changelist_classifier(report), [])
 
@@ skipping 58 matching lines @@
 
     expected_suspects = [
         {
             'review_url': 'https://codereview.chromium.org/3281',
             'url': 'https://repo.test/+/3',
             'author': 'e@chromium.org',
             'time': 'Thu Apr 1 21:24:43 2016',
             'project_path': 'src/',
             'revision': '3',
             'confidence': math.log(0.2857142857142857 * 0.6),
-            'reasons': [
-                ('MinDistance', math.log(0.6), 'Minimum distance is 20'),
-                ('TopFrameIndex', math.log(0.2857142857142857),
-                    'Top frame is #5')],
+            'reasons': ('MinDistance: -0.510826 -- Minimum distance is 20\n'
+                        'TopFrameIndex: -1.252763 -- Top frame is #5'),
             'changed_files': [
                 {
                     'file': 'a.cc',
                     'blame_url': None,
                     'info': 'Minimum distance (LOC) 20, frame #5',
                 }],
         }, {
             'review_url': 'https://codereview.chromium.org/3281',
             'url': 'https://repo.test/+/1',
             'author': 'r@chromium.org',
             'time': 'Thu Mar 31 21:24:43 2016',
             'project_path': 'src/',
             'revision': '1',
             'confidence': 0.,
-            'reasons': [
-                ('MinDistance', 0., 'Minimum distance is 0'),
-                ('TopFrameIndex', 0., 'Top frame is #0')],
+            'reasons': ('MinDistance: 0.000000 -- Minimum distance is 0\n'
+                        'TopFrameIndex: 0.000000 -- Top frame is #0'),
             'changed_files': [
                 {
                     'file': 'a.cc',
                     'blame_url': None,
                     'info': 'Minimum distance (LOC) 0, frame #0',
                 }],
         },
     ]
     self.assertListEqual([suspect.ToDict() for suspect in suspects],
                          expected_suspects)
@@ skipping 41 matching lines @@
             'author': 'r@chromium.org',
             'changed_files': [
                 {
                     'blame_url': None,
                     'file': 'a.cc',
                     'info': 'Minimum distance (LOC) 1, frame #0'
                 }
             ],
             'confidence': math.log(0.98),
             'project_path': 'src/',
-            'reasons': [
-                ('MinDistance', math.log(0.98), 'Minimum distance is 1'),
-                ('TopFrameIndex', 0., 'Top frame is #0'),
-            ],
+            'reasons': ('MinDistance: -0.020203 -- Minimum distance is 1\n'
+                        'TopFrameIndex: 0.000000 -- Top frame is #0'),
             'review_url': 'https://codereview.chromium.org/3281',
             'revision': '1',
             'time': 'Thu Mar 31 21:24:43 2016',
             'url': 'https://repo.test/+/1'
         },
     ]
     self.assertListEqual([suspect.ToDict() for suspect in suspects],
                          expected_suspects)
 
   def testFinditForCrashAllSuspectsWithZeroConfidences(self):
@@ skipping 25 matching lines @@
           'f.cc': AnalysisInfo(min_distance=20, min_distance_frame=frame3)
       }
 
       return [suspect1, suspect2]
 
     self.mock(scorer_changelist_classifier, 'FindSuspects', _MockFindSuspects)
 
     suspects = self.changelist_classifier(DUMMY_REPORT)
     self.assertFalse(suspects, 'Expected zero suspects, but found some:\n%s'
         % pprint.pformat([suspect.ToDict() for suspect in suspects]))