Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: src/objects-debug.cc

Issue 2625073002: Revert of Internalize strings in-place (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-body-descriptors-inl.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index f770533a1b8f5e09da39d87776bc23d914a09414..ee39fdd069c43bd2b35e2ccf27ac6ef21a3a3aed 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -555,8 +555,6 @@
ConsString::cast(this)->ConsStringVerify();
} else if (IsSlicedString()) {
SlicedString::cast(this)->SlicedStringVerify();
- } else if (IsThinString()) {
- ThinString::cast(this)->ThinStringVerify();
}
}
@@ -568,17 +566,12 @@
CHECK(this->length() >= ConsString::kMinLength);
CHECK(this->length() == this->first()->length() + this->second()->length());
if (this->IsFlat()) {
- // A flat cons can only be created by String::SlowFlatten.
- // Afterwards, the first part may be externalized or internalized.
- CHECK(this->first()->IsSeqString() || this->first()->IsExternalString() ||
- this->first()->IsThinString());
- }
-}
-
-void ThinString::ThinStringVerify() {
- CHECK(this->actual()->IsInternalizedString());
- CHECK(this->actual()->IsSeqString() || this->actual()->IsExternalString());
-}
+ // A flat cons can only be created by String::SlowTryFlatten.
+ // Afterwards, the first part may be externalized.
+ CHECK(this->first()->IsSeqString() || this->first()->IsExternalString());
+ }
+}
+
void SlicedString::SlicedStringVerify() {
CHECK(!this->parent()->IsConsString());
« no previous file with comments | « src/objects-body-descriptors-inl.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698