Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2625053007: [i18n] remove unneeded spans (Closed)

Created:
3 years, 11 months ago by dschuyler
Modified:
3 years, 11 months ago
Reviewers:
tommycli
CC:
chromium-reviews, alemate+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[i18n] remove unneeded spans This CL removes unneeded spans from the prior i18n-content replacements and changes a <br> to a <div> per presubmit: line 4: Do not use <br>; place blocking elements (<div>) as appropriate. $i18n{appListText1}<br> ^^^ BUG=677338 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/first_run/app/main.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/first_run/app_list_step.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
dschuyler
follow-up from https://codereview.chromium.org/2625873006/
3 years, 11 months ago (2017-01-12 20:36:15 UTC) #4
tommycli
3 years, 11 months ago (2017-01-12 21:10:35 UTC) #6
On 2017/01/12 20:36:15, dschuyler wrote:
> follow-up from https://codereview.chromium.org/2625873006/

Per our lunch convo, let's just leave this as-is.

Thanks for taking the time to followup, but since our lunch convo, my latest
thinking is probably to just update every i18n leaving the dom structure as-is.
We can discuss more in person if you want.

Powered by Google App Engine
This is Rietveld 408576698