VM: [Kernel] Add toString() support for generated enum classes

tests/language/enum_test.dart

Index: tests/language/enum_test.dart
diff --git a/tests/language/enum_test.dart b/tests/language/enum_test.dart
index a3b458632d92dbd9f03c07c1d89f524f79fb8637..ab24b629905c52e3466789b82aea18bb0ced7e74 100644
--- a/tests/language/enum_test.dart
+++ b/tests/language/enum_test.dart
@@ -20,7 +20,8 @@ main() {
   Expect.equals('Enum2.A', Enum2.A.toString());
   Expect.equals(0, Enum2.A.index);
   Expect.listEquals([Enum2.A], Enum2.values);
-  Expect.identical(const [Enum2.A], Enum2.values);
+  Expect.isTrue(identical(const [Enum2.A], Enum2.values) ||
+                identical(const <Enum2>[Enum2.A], Enum2.values));

[kustermann, 2017/01/11 12:25:06]

I think dartk does the right thing by making the const list be a `const
<Enum2>[]` instead of a `const <dynamic>[]`. So I modified the test.

[Vyacheslav Egorov (Google), 2017/01/11 17:28:28]

I think it should be only one or another. 

Per specification E.values has type List<E> so the test was wrong.

We might want to file bugs against VM and dart2js about it.

[Lasse Reichstein Nielsen, 2017/01/11 17:55:00]

Agree, the spec is clear. Do file bugs (or say so, and I'll do it).

[Vyacheslav Egorov (Google), 2017/01/11 17:56:29]

It would be nice if you do that :) Thanks a (metric) ton!

   Enum2.values.forEach(test2);
 
   Expect.equals('Enum3.B', Enum3.B.toString());