Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp

Issue 2625043002: Use a new Supplement constructor in ScreenOrientationController (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp
index 6a80ef90e209c41bb07198e5001ca80322e2d81b..ad490be64e76657f9d37e70c51234d098adf2dd2 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp
@@ -92,15 +92,13 @@ class StubFrameLoaderClient : public EmptyFrameLoaderClient {
};
class MockScreenOrientationController final
- : public GarbageCollectedFinalized<MockScreenOrientationController>,
- public ScreenOrientationController {
- USING_GARBAGE_COLLECTED_MIXIN(MockScreenOrientationController);
+ : public ScreenOrientationController {
WTF_MAKE_NONCOPYABLE(MockScreenOrientationController);
public:
static MockScreenOrientationController* provideTo(LocalFrame& frame) {
MockScreenOrientationController* controller =
- new MockScreenOrientationController();
+ new MockScreenOrientationController(frame);
ScreenOrientationController::provideTo(frame, controller);
return controller;
}
@@ -108,10 +106,11 @@ class MockScreenOrientationController final
MOCK_METHOD1(lock, void(WebScreenOrientationLockType));
MOCK_METHOD0(mockUnlock, void());
- DEFINE_INLINE_VIRTUAL_TRACE() { Supplement<LocalFrame>::trace(visitor); }
+ DEFINE_INLINE_VIRTUAL_TRACE() { ScreenOrientationController::trace(visitor); }
private:
- MockScreenOrientationController() = default;
+ explicit MockScreenOrientationController(LocalFrame& frame)
+ : ScreenOrientationController(frame) {}
void lock(WebScreenOrientationLockType type,
std::unique_ptr<WebLockOrientationCallback>) override {

Powered by Google App Engine
This is Rietveld 408576698