Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2624973004: VM: [Kernel] Merge common test expectations from language_kernel.status -> language.status (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [Kernel] Merge common test expectations from language_kernel.status -> language.status R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/36b16c6f1c5a15be0082a2c6a2f05303b090f6f9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -81 lines) Patch
M tests/language/language.status View 1 3 chunks +14 lines, -14 lines 0 comments Download
M tests/language/language_kernel.status View 1 6 chunks +0 lines, -67 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kustermann
3 years, 11 months ago (2017-01-11 16:28:46 UTC) #2
Vyacheslav Egorov (Google)
LGTM with commented out status line explained and/or removed. https://codereview.chromium.org/2624973004/diff/1/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/2624973004/diff/1/tests/language/language.status#newcode50 tests/language/language.status:50: ...
3 years, 11 months ago (2017-01-11 17:15:27 UTC) #3
kustermann
Committed patchset #2 (id:20001) manually as 36b16c6f1c5a15be0082a2c6a2f05303b090f6f9 (presubmit successful).
3 years, 11 months ago (2017-01-11 19:08:29 UTC) #6
kustermann
3 years, 11 months ago (2017-01-11 19:12:19 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2624973004/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/2624973004/diff/1/tests/language/language.sta...
tests/language/language.status:50: #redirecting_constructor_initializer_test:
RuntimeError # Issue 23488
On 2017/01/11 17:15:27, Vyacheslav Egorov (Google) wrote:
> Why is this commented out?

Done.

Powered by Google App Engine
This is Rietveld 408576698