Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: ios/chrome/browser/ui/omnibox/page_info_model.cc

Issue 2624963004: iOS: Add the Page Info password/credit card string for HTTP pages. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/omnibox/page_info_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/omnibox/page_info_model.cc
diff --git a/ios/chrome/browser/ui/omnibox/page_info_model.cc b/ios/chrome/browser/ui/omnibox/page_info_model.cc
index a524461157a22f0619445af7e6d2dfb405ab9fc6..7b94d60b9a6c8c0778ce7d5432469a88e6bf8ed5 100644
--- a/ios/chrome/browser/ui/omnibox/page_info_model.cc
+++ b/ios/chrome/browser/ui/omnibox/page_info_model.cc
@@ -131,7 +131,7 @@ PageInfoModel::PageInfoModel(ios::ChromeBrowserState* browser_state,
description.assign(l10n_util::GetStringUTF16(
IDS_PAGE_INFO_SECURITY_TAB_INSECURE_IDENTITY));
icon_id = ssl.security_style == web::SECURITY_STYLE_UNAUTHENTICATED
- ? ICON_NONE
+ ? ICON_STATE_INFO
: ICON_STATE_ERROR;
const base::string16 bullet = base::UTF8ToUTF16("\n • ");
@@ -160,11 +160,12 @@ PageInfoModel::PageInfoModel(ios::ChromeBrowserState* browser_state,
if (!ssl.certificate) {
// Not HTTPS.
icon_id = ssl.security_style == web::SECURITY_STYLE_UNAUTHENTICATED
- ? ICON_NONE
+ ? ICON_STATE_INFO
: ICON_STATE_ERROR;
- description.assign(l10n_util::GetStringFUTF16(
- IDS_PAGE_INFO_SECURITY_TAB_NOT_ENCRYPTED_CONNECTION_TEXT,
- subject_name));
+ description.assign(
+ l10n_util::GetStringUTF16(IDS_PAGEINFO_NOT_SECURE_SUMMARY));
+ description += base::ASCIIToUTF16("\n\n");
+ description += l10n_util::GetStringUTF16(IDS_PAGEINFO_NOT_SECURE_DETAILS);
} else if (ssl.security_bits < 0) {
if (ssl.content_status == web::SSLStatus::DISPLAYED_INSECURE_CONTENT) {
DCHECK(description.empty());
« no previous file with comments | « no previous file | ios/chrome/browser/ui/omnibox/page_info_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698