Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: ios/chrome/browser/ui/history/tab_history_cell.h

Issue 2624963003: [ObjC ARC] Converts ios/chrome/browser/ui/history:history to ARC. (Closed)
Patch Set: Reparent and fix tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/history/tab_history_cell.h
diff --git a/ios/chrome/browser/ui/history/tab_history_cell.h b/ios/chrome/browser/ui/history/tab_history_cell.h
index 365ce4b0d5e9c0635eeffa856ee33a2ec00d9ff4..94e905f24284524db7d347120bcdd07f1ebc2069 100644
--- a/ios/chrome/browser/ui/history/tab_history_cell.h
+++ b/ios/chrome/browser/ui/history/tab_history_cell.h
@@ -11,14 +11,14 @@
// Table cell used in TabHistoryViewController.
@interface TabHistoryCell : UICollectionViewCell
-@property(nonatomic, retain) CRWSessionEntry* entry;
-@property(nonatomic, readonly) UILabel* titleLabel;
+@property(nonatomic, strong) CRWSessionEntry* entry;
+@property(weak, nonatomic, readonly) UILabel* titleLabel;
lpromero 2017/01/11 18:03:52 Weird how it puts it at the beginning. Anything we
stkhapugin 2017/01/12 14:15:44 I don't think we're consistent with property quali
@end
// Header for a section of TabHistoryCells.
@interface TabHistorySectionHeader : UICollectionReusableView
-@property(nonatomic, readonly) UIImageView* iconView;
-@property(nonatomic, readonly) UIView* lineView;
+@property(weak, nonatomic, readonly) UIImageView* iconView;
+@property(weak, nonatomic, readonly) UIView* lineView;
@end
// Footer for a section of TabHistoryCells.

Powered by Google App Engine
This is Rietveld 408576698