[ObjC ARC] Converts ios/chrome/browser/ui/history:history to ARC.

ios/chrome/browser/ui/history/history_entry_item.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/history/history_entry_item.h"
 
 #include "base/i18n/time_formatting.h"
-#include "base/ios/weak_nsobject.h"
 #import "base/mac/foundation_util.h"
-#import "base/mac/objc_property_releaser.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/history/core/browser/url_row.h"
 #include "components/strings/grit/components_strings.h"
 #include "components/url_formatter/url_formatter.h"
 #include "ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h"
 #import "ios/chrome/browser/ui/history/favicon_view.h"
 #import "ios/chrome/browser/ui/history/favicon_view_provider.h"
 #import "ios/chrome/browser/ui/history/history_entry.h"
 #include "ios/chrome/browser/ui/rtl_geometry.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ios/chrome/grit/ios_strings.h"
 #import "ios/third_party/material_components_ios/src/components/Palettes/src/MaterialPalettes.h"
 #import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
 #include "ui/base/l10n/l10n_util.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace {
 // Size at which the favicon will be displayed.
 const CGFloat kFaviconSize = 24.0;
 // Minimum size at which to fetch favicons.
 const CGFloat kMinFaviconSize = 16.0;
 // Horizontal spacing between edge of the cell and the cell content.
 const CGFloat kMargin = 16.0;
 // Horizontal spacing between the leading edge of the cell and the text.
 const CGFloat kHeaderMargin = 56.0;
 
@@ skipping 15 matching lines @@
     else
       base::i18n::AdjustStringForLocaleDirection(&formatted_title);
   }
   return base::SysUTF16ToNSString(formatted_title);
 }
 }  // namespace
 
 #pragma mark - HistoryEntryItem
 
 @interface HistoryEntryItem ()<FaviconViewProviderDelegate> {
-  // Property releaser for HistoryEntryItem.
-  base::mac::ObjCPropertyReleaser _propertyReleaser_HistoryEntryItem;
   // Delegate for HistoryEntryItem.
-  base::WeakNSProtocol<id<HistoryEntryItemDelegate>> _delegate;
+  __weak id<HistoryEntryItemDelegate> _delegate;
 }
 
 // FaviconViewProvider to fetch the favicon and format the favicon view.
-@property(nonatomic, retain) FaviconViewProvider* faviconViewProvider;
+@property(nonatomic, strong) FaviconViewProvider* faviconViewProvider;
 
 // Custom accessibility actions for the history entry view.
 - (NSArray*)accessibilityActions;
 // Custom accessibility action to delete the history entry.
 - (BOOL)deleteHistoryEntry;
 // Custom accessibility action to open the history entry's URL in a new tab.
 - (BOOL)openInNewTab;
 // Custom accessibility action to open the history entry's URL in a new
 // incognito tab.
 - (BOOL)openInNewIncognitoTab;
 // Custom accessibility action to copy the history entry's URL to the clipboard.
 - (BOOL)copyURL;
 @end
 
 @implementation HistoryEntryItem
 
 @synthesize faviconViewProvider = _faviconViewProvider;
 @synthesize text = _text;
 @synthesize detailText = _detailText;
 @synthesize timeText = _timeText;
 @synthesize URL = _URL;
 @synthesize timestamp = _timestamp;
 
 - (instancetype)initWithType:(NSInteger)type
                 historyEntry:(const history::HistoryEntry&)entry
                 browserState:(ios::ChromeBrowserState*)browserState
                     delegate:(id<HistoryEntryItemDelegate>)delegate {
   self = [super initWithType:type];
   if (self) {
-    _propertyReleaser_HistoryEntryItem.Init(self, [HistoryEntryItem class]);
     self.cellClass = [HistoryEntryCell class];
     favicon::LargeIconService* largeIconService =
         IOSChromeLargeIconServiceFactory::GetForBrowserState(browserState);
     _faviconViewProvider =
         [[FaviconViewProvider alloc] initWithURL:entry.url
                                      faviconSize:kFaviconSize
                                   minFaviconSize:kMinFaviconSize
                                 largeIconService:largeIconService
                                         delegate:self];
     _text = [FormattedTitle(entry.title, entry.url) copy];
     _detailText = [base::SysUTF8ToNSString(entry.url.spec()) copy];
     _timeText =
         [base::SysUTF16ToNSString(base::TimeFormatTimeOfDay(entry.time)) copy];
     _URL = GURL(entry.url);
     _timestamp = entry.time;
-    _delegate.reset(delegate);
+    _delegate = delegate;
   }
   return self;
 }
 
 - (instancetype)initWithType:(NSInteger)type {
   NOTREACHED();
   return nil;
 }
 
 - (BOOL)isEqualToHistoryEntryItem:(HistoryEntryItem*)item {
@@ skipping 10 matching lines @@
   return [self isEqualToHistoryEntryItem:object];
 }
 
 - (NSUInteger)hash {
   return [base::SysUTF8ToNSString(self.URL.spec()) hash] ^
          self.timestamp.ToInternalValue();
 }
 
 - (NSArray*)accessibilityActions {
   UIAccessibilityCustomAction* deleteAction =
-      [[[UIAccessibilityCustomAction alloc]
+      [[UIAccessibilityCustomAction alloc]
           initWithName:l10n_util::GetNSString(
                            IDS_HISTORY_ENTRY_ACCESSIBILITY_DELETE)
                 target:self
-              selector:@selector(deleteHistoryEntry)] autorelease];
+              selector:@selector(deleteHistoryEntry)];
   UIAccessibilityCustomAction* openInNewTabAction =
-      [[[UIAccessibilityCustomAction alloc]
+      [[UIAccessibilityCustomAction alloc]
           initWithName:l10n_util::GetNSString(
                            IDS_IOS_CONTENT_CONTEXT_OPENLINKNEWTAB)
                 target:self
-              selector:@selector(openInNewTab)] autorelease];
+              selector:@selector(openInNewTab)];
   UIAccessibilityCustomAction* openInNewIncognitoTabAction =
-      [[[UIAccessibilityCustomAction alloc]
+      [[UIAccessibilityCustomAction alloc]
           initWithName:l10n_util::GetNSString(
                            IDS_IOS_CONTENT_CONTEXT_OPENLINKNEWINCOGNITOTAB)
                 target:self
-              selector:@selector(openInNewIncognitoTab)] autorelease];
+              selector:@selector(openInNewIncognitoTab)];
   UIAccessibilityCustomAction* copyURLAction =
-      [[[UIAccessibilityCustomAction alloc]
+      [[UIAccessibilityCustomAction alloc]
           initWithName:l10n_util::GetNSString(IDS_IOS_CONTENT_CONTEXT_COPY)
                 target:self
-              selector:@selector(copyURL)] autorelease];
+              selector:@selector(copyURL)];
   return @[
     deleteAction, openInNewTabAction, openInNewIncognitoTabAction, copyURLAction
   ];
 }
 
 - (BOOL)deleteHistoryEntry {
   [_delegate historyEntryItemDidRequestDelete:self];
   return YES;
 }
 
@@ skipping 37 matching lines @@
 - (void)faviconViewProviderFaviconDidLoad:(FaviconViewProvider*)provider {
   [_delegate historyEntryItemShouldUpdateView:self];
 }
 
 @end
 
 #pragma mark - HistoryEntryCell
 
 @interface HistoryEntryCell () {
   // Property releaser for HistoryEntryCell.
-  base::mac::ObjCPropertyReleaser _propertyReleaser_HistoryEntryCell;
 }
 
 // Redeclare as readwrite to allow property releaser to handle these properties.

[lpromero, 2017/01/11 18:03:52]

Remove the part of the comment about the property releaser.

[stkhapugin, 2017/01/12 14:15:44]

Done.

-@property(nonatomic, readwrite, retain) UILabel* textLabel;
-@property(nonatomic, readwrite, retain) UILabel* detailTextLabel;
-@property(nonatomic, readwrite, retain) UILabel* timeLabel;
+@property(nonatomic, readwrite, strong) UILabel* textLabel;
+@property(nonatomic, readwrite, strong) UILabel* detailTextLabel;
+@property(nonatomic, readwrite, strong) UILabel* timeLabel;
 @end
 
 @implementation HistoryEntryCell
 
 @synthesize faviconViewContainer = _faviconViewContainer;
 @synthesize textLabel = _textLabel;
 @synthesize detailTextLabel = _detailTextLabel;
 @synthesize timeLabel = _timeLabel;
 
 - (id)initWithFrame:(CGRect)frame {
   self = [super initWithFrame:frame];
   if (self) {
-    _propertyReleaser_HistoryEntryCell.Init(self, [HistoryEntryCell class]);
 
     _faviconViewContainer = [[UIView alloc] initWithFrame:CGRectZero];
 
     _textLabel = [[UILabel alloc] initWithFrame:CGRectZero];
     [_textLabel
         setFont:[[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:16]];
     [_textLabel setTextColor:[[MDCPalette greyPalette] tint900]];
 
     _detailTextLabel = [[UILabel alloc] initWithFrame:CGRectZero];
     [_detailTextLabel
@@ skipping 51 matching lines @@
   [super prepareForReuse];
   _textLabel.text = nil;
   _detailTextLabel.text = nil;
   _timeLabel.text = nil;
   for (UIView* subview in _faviconViewContainer.subviews) {
     [subview removeFromSuperview];
   }
 }
 
 @end