Non-US OS region generates invalid trace JSON.

Non-US OS region generates invalid trace JSON.

JSON output from the trace logging has floats formatted
to the current user locale, which can make opening the
trace fail.

R=
BUG=304818
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227730

[dsinclair, 2013-10-07 14:26:51]

lgtm

https://codereview.chromium.org/26249002/diff/1/base/debug/trace_event_impl.cc
File base/debug/trace_event_impl.cc (right):

https://codereview.chromium.org/26249002/diff/1/base/debug/trace_event_impl.c...
base/debug/trace_event_impl.cc:514: std::string real =
DoubleToString(value.as_double);
Can we add a TODO in here since this is the same as the code in
base/json/json_writer.cc to make a common method?

[Erik Dahlström (inactive), 2013-10-07 15:00:52]

https://codereview.chromium.org/26249002/diff/1/base/debug/trace_event_impl.cc
File base/debug/trace_event_impl.cc (right):

https://codereview.chromium.org/26249002/diff/1/base/debug/trace_event_impl.c...
base/debug/trace_event_impl.cc:514: std::string real =
DoubleToString(value.as_double);
On 2013/10/07 14:26:51, dsinclair wrote:
> Can we add a TODO in here since this is the same as the code in
> base/json/json_writer.cc to make a common method?

Done.

[commit-bot: I haz the power, 2013-10-09 08:14:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/26249002/5001

[commit-bot: I haz the power, 2013-10-09 08:52:03]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-10-09 11:15:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ed@opera.com/26249002/5001

[commit-bot: I haz the power, 2013-10-09 13:35:00]

Change committed as 227730