third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp - Issue 2624893003: Move the FontFaceCache stored in CSSFontSelector to be stored in Document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp

Issue 2624893003: Move the FontFaceCache stored in CSSFontSelector to be stored in Document. (Closed)

Patch Set: Remove an unneccessary forward declaration Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/FontFaceSet.cpp ('k') | third_party/WebKit/Source/core/dom/Document.h » ('j') | third_party/WebKit/Source/core/dom/Document.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp

index 373a63e7b25d02f63714b062e058f8177ba9d78f..75421c69108a22de692491de270752390112af13 100644

--- a/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp

@@ -76,8 +76,7 @@ void ScopedStyleResolver::addFontFaceRules(const RuleSet& ruleSet) {

ruleSet.fontFaceRules();

for (auto& fontFaceRule : fontFaceRules) {

if (FontFace* fontFace = FontFace::create(&document, fontFaceRule))

- cssFontSelector->fontFaceCache()->add(cssFontSelector, fontFaceRule,

- fontFace);

+ document.fontFaceCache()->add(cssFontSelector, fontFaceRule, fontFace);

}

if (fontFaceRules.size() && document.styleResolver())

document.styleResolver()->invalidateMatchedPropertiesCache();