third_party/WebKit/Source/core/dom/StyleEngine.cpp - Issue 2624893003: Move the FontFaceCache stored in CSSFontSelector to be stored in Document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/StyleEngine.cpp

Issue 2624893003: Move the FontFaceCache stored in CSSFontSelector to be stored in Document. (Closed)

Patch Set: Add a helper function Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/StyleEngine.cpp

diff --git a/third_party/WebKit/Source/core/dom/StyleEngine.cpp b/third_party/WebKit/Source/core/dom/StyleEngine.cpp

index 57e5ed09d1b8f3abbdbbb351f6b2041c7cee00b9..b78ecc49cb75282df78d7c58ffbc5535bad96fa5 100644

--- a/third_party/WebKit/Source/core/dom/StyleEngine.cpp

+++ b/third_party/WebKit/Source/core/dom/StyleEngine.cpp

@@ -456,7 +456,7 @@ void StyleEngine::didDetach() {

void StyleEngine::clearFontCache() {

if (m_fontSelector)

- m_fontSelector->fontFaceCache()->clearCSSConnected();

+ m_document->fontFaceCache()->clearCSSConnected();

if (m_resolver)

m_resolver->invalidateMatchedPropertiesCache();

}

@@ -480,7 +480,7 @@ void StyleEngine::removeFontFaceRules(

if (!m_fontSelector)

return;

- FontFaceCache* cache = m_fontSelector->fontFaceCache();

+ FontFaceCache* cache = m_document->fontFaceCache();

for (const auto& rule : fontFaceRules)

cache->remove(rule);

if (m_resolver)