Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp

Issue 2624893002: M-56: Replace mojo::MakeRequest with mojo::GetProxy. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/permissions/PermissionStatus.h" 5 #include "modules/permissions/PermissionStatus.h"
6 6
7 #include "bindings/core/v8/ScriptPromiseResolver.h" 7 #include "bindings/core/v8/ScriptPromiseResolver.h"
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/events/Event.h" 9 #include "core/events/Event.h"
10 #include "modules/EventTargetModulesNames.h" 10 #include "modules/EventTargetModulesNames.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 return "prompt"; 82 return "prompt";
83 } 83 }
84 84
85 ASSERT_NOT_REACHED(); 85 ASSERT_NOT_REACHED();
86 return "denied"; 86 return "denied";
87 } 87 }
88 88
89 void PermissionStatus::startListening() { 89 void PermissionStatus::startListening() {
90 DCHECK(!m_binding.is_bound()); 90 DCHECK(!m_binding.is_bound());
91 mojom::blink::PermissionObserverPtr observer; 91 mojom::blink::PermissionObserverPtr observer;
92 m_binding.Bind(mojo::MakeRequest(&observer)); 92 m_binding.Bind(mojo::GetProxy(&observer));
93 93
94 mojom::blink::PermissionServicePtr service; 94 mojom::blink::PermissionServicePtr service;
95 connectToPermissionService(getExecutionContext(), 95 connectToPermissionService(getExecutionContext(), mojo::GetProxy(&service));
96 mojo::MakeRequest(&service));
97 service->AddPermissionObserver(m_descriptor->Clone(), 96 service->AddPermissionObserver(m_descriptor->Clone(),
98 getExecutionContext()->getSecurityOrigin(), 97 getExecutionContext()->getSecurityOrigin(),
99 m_status, std::move(observer)); 98 m_status, std::move(observer));
100 } 99 }
101 100
102 void PermissionStatus::stopListening() { 101 void PermissionStatus::stopListening() {
103 m_binding.Close(); 102 m_binding.Close();
104 } 103 }
105 104
106 void PermissionStatus::OnPermissionStatusChange(MojoPermissionStatus status) { 105 void PermissionStatus::OnPermissionStatusChange(MojoPermissionStatus status) {
107 if (m_status == status) 106 if (m_status == status)
108 return; 107 return;
109 108
110 m_status = status; 109 m_status = status;
111 dispatchEvent(Event::create(EventTypeNames::change)); 110 dispatchEvent(Event::create(EventTypeNames::change));
112 } 111 }
113 112
114 DEFINE_TRACE(PermissionStatus) { 113 DEFINE_TRACE(PermissionStatus) {
115 EventTargetWithInlineData::trace(visitor); 114 EventTargetWithInlineData::trace(visitor);
116 ActiveDOMObject::trace(visitor); 115 ActiveDOMObject::trace(visitor);
117 } 116 }
118 117
119 } // namespace blink 118 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698