Add support for cellular geolocation

chrome/browser/chromeos/system/timezone_resolver_manager.cc

Index: chrome/browser/chromeos/system/timezone_resolver_manager.cc
diff --git a/chrome/browser/chromeos/system/timezone_resolver_manager.cc b/chrome/browser/chromeos/system/timezone_resolver_manager.cc
index ac9f3586e9be59299e067fa283bab8e3f4363559..c1e8317f5ba85b51c0420dbaca11c6ec1644809e 100644
--- a/chrome/browser/chromeos/system/timezone_resolver_manager.cc
+++ b/chrome/browser/chromeos/system/timezone_resolver_manager.cc
@@ -54,6 +54,8 @@ ServiceConfiguration GetServiceConfigurationFromAutomaticDetectionPolicy() {
       return SHOULD_START;
     case enterprise_management::SystemTimezoneProto::SEND_WIFI_ACCESS_POINTS:
       return SHOULD_START;
+    case enterprise_management::SystemTimezoneProto::SEND_ALL_LOCATION_INFO:
+      return SHOULD_START;
   }
   // Default for unknown policy value.
   NOTREACHED() << "Unrecognized policy value: " << policy_value;
@@ -128,6 +130,19 @@ void TimeZoneResolverManager::SetPrimaryUserPrefs(PrefService* pref_service) {
 }
 
 bool TimeZoneResolverManager::ShouldSendWiFiGeolocationData() {
+  return (
+      (GetTimezoneManagementSetting() ==
+       enterprise_management::SystemTimezoneProto::SEND_WIFI_ACCESS_POINTS) ||
+      (GetTimezoneManagementSetting() ==
+       enterprise_management::SystemTimezoneProto::SEND_ALL_LOCATION_INFO));

[stevenjb, 2017/02/09 20:12:52]

This still calls GetTimezoneManagementSetting() twice. You need a local here.

[can Skylar cook, 2017/02/09 21:10:45]

D'oh

+}
+
+bool TimeZoneResolverManager::ShouldSendCellularGeolocationData() {
+  return (GetTimezoneManagementSetting() ==
+          enterprise_management::SystemTimezoneProto::SEND_ALL_LOCATION_INFO);
+}
+
+int TimeZoneResolverManager::GetTimezoneManagementSetting() {
   PrefService* local_state = g_browser_process->local_state();
   const bool is_managed = local_state->IsManagedPreference(
       prefs::kSystemTimezoneAutomaticDetectionPolicy);
@@ -140,8 +155,7 @@ bool TimeZoneResolverManager::ShouldSendWiFiGeolocationData() {
   DCHECK(policy_value <= enterprise_management::SystemTimezoneProto::
                              AutomaticTimezoneDetectionType_MAX);
 
-  return policy_value ==
-         enterprise_management::SystemTimezoneProto::SEND_WIFI_ACCESS_POINTS;
+  return policy_value;
 }
 
 void TimeZoneResolverManager::UpdateTimezoneResolver() {