LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js - Issue 26248003: Do not special case null for URLUtils attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js

Issue 26248003: Do not special case null for URLUtils attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix linux specific exceptions again Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js ('k') | LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js

diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js b/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js

index 7ff0b3f54b6b92ded7f555d042e35df61db7e41c..44412f1ca5dfb3ce16aee2190fc0aafb7824184b 100644

--- a/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js

+++ b/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js

@@ -32,11 +32,10 @@ a.href = "https://www.mydomain.com/path/testurl.html?key=value";

a.pathname = "/it/../path";

shouldBe("a.href", "'https://www.mydomain.com/path?key=value'");

-// IE8 converts null to "null", which is not the right thing to do.

debug("Set pathname to null");

a.href = "https://www.mydomain.com/path/testurl.html?key=value";

a.pathname = null;

-shouldBe("a.href", "'https://www.mydomain.com/?key=value'");

+shouldBe("a.href", "'https://www.mydomain.com/null?key=value'");

debug("Set pathname to empty string");

a.href = "https://www.mydomain.com/?key=value";