LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js - Issue 26248003: Do not special case null for URLUtils attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js

Issue 26248003: Do not special case null for URLUtils attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js ('k') | LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js » ('j') | LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js

diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js b/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js

index f112a9cddbc7e9200634b4dc17110034064b676c..3c47b10a6172087492899cf77adccd06c6cb6c2e 100644

--- a/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js

+++ b/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js

@@ -23,13 +23,10 @@ a.href = "foo://www.mydomain.com/path/";

a.hostname = "www.otherdomain.com";

shouldBe("a.href", "'foo://www.otherdomain.com/path/'");

-// IE8 converts null to "null", which is not the right thing to do.

-// Firefox 3.5.2 allows setting the hostname to null, which is wrong per

-// http://dev.w3.org/html5/spec/infrastructure.html#url-decomposition-idl-attributes .

debug("Set hostname to null");

a.href = "https://www.mydomain.com:8080/path/";

a.hostname = null;

-shouldBe("a.href", "'https://www.mydomain.com:8080/path/'");

+shouldBe("a.href", "'https://null:8080/path/'");

// Both IE8 and Firefox 3.5.2 allow setting the host to empty string, against the spec at

// http://dev.w3.org/html5/spec/infrastructure.html#url-decomposition-idl-attributes .