Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26248003: Do not special case null for URLUtils attributes (Closed)

Created:
7 years, 2 months ago by arv (Not doing code reviews)
Modified:
7 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, do-not-use
Visibility:
Public.

Description

Do not special case null for URLUtils attributes http://url.spec.whatwg.org/#api The WebIDL attributes in the spec do not special case null and this matches Firefox and IE. BUG=304946 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159126

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated platform specific results #

Patch Set 3 : Fix linux specific exceptions again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -38 lines) Patch
M LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt View 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt View 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt View 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.idl View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
arv (Not doing code reviews)
https://codereview.chromium.org/26248003/diff/1/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt File LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt (right): https://codereview.chromium.org/26248003/diff/1/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt#newcode21 LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:21: FAIL a.href should be https://null:8080/path/. Was https://null/path/. This is ...
7 years, 2 months ago (2013-10-07 21:23:42 UTC) #1
do-not-use
Lgtm but needs an api owner to approve as well.
7 years, 2 months ago (2013-10-07 22:23:34 UTC) #2
abarth-chromium
Yay for the world becoming more sane.
7 years, 2 months ago (2013-10-07 22:28:03 UTC) #3
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-07 22:28:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/26248003/1
7 years, 2 months ago (2013-10-08 00:30:12 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=6666
7 years, 2 months ago (2013-10-08 03:31:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/26248003/21001
7 years, 2 months ago (2013-10-08 14:33:00 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=7185
7 years, 2 months ago (2013-10-08 15:33:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/26248003/36001
7 years, 2 months ago (2013-10-08 15:47:43 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-08 16:49:34 UTC) #10
Message was sent while issue was closed. 
Change committed as 159126

Powered by Google App Engine
This is Rietveld 408576698