Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2624793002: Make error producing tests ansynchronous. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make error producing tests ansynchronous. This is another preliminary test to run these tests with the new analysis driver. Especially when we're going to replace the task based analysis implementation with another one. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5a3afed30f367843bc0c72fe25e77c9205d7649f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5313 lines, -5121 lines) Patch
M pkg/analyzer/test/generated/all_the_rest_test.dart View 85 chunks +324 lines, -322 lines 1 comment Download
M pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart View 20 chunks +86 lines, -86 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 209 chunks +1226 lines, -1074 lines 0 comments Download
M pkg/analyzer/test/generated/error_suppression_test.dart View 1 chunk +34 lines, -34 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 184 chunks +581 lines, -581 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 238 chunks +973 lines, -977 lines 0 comments Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 62 chunks +188 lines, -188 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 166 chunks +249 lines, -241 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 11 chunks +39 lines, -38 lines 0 comments Download
M pkg/analyzer/test/generated/simple_resolver_test.dart View 98 chunks +161 lines, -158 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_analyzer_test.dart View 90 chunks +109 lines, -109 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 189 chunks +424 lines, -427 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 164 chunks +597 lines, -558 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 89 chunks +190 lines, -189 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart View 77 chunks +132 lines, -139 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-10 17:51:29 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2624793002/diff/1/pkg/analyzer/test/generated/all_the_rest_test.dart File pkg/analyzer/test/generated/all_the_rest_test.dart (right): https://codereview.chromium.org/2624793002/diff/1/pkg/analyzer/test/generated/all_the_rest_test.dart#newcode98 pkg/analyzer/test/generated/all_the_rest_test.dart:98: test_setContents() async { Not sure there's value in ...
3 years, 11 months ago (2017-01-10 18:02:40 UTC) #2
scheglov
3 years, 11 months ago (2017-01-10 18:33:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a3afed30f367843bc0c72fe25e77c9205d7649f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698